build: use build-ci for benchmark merge-commit rebuild - #65362
Merged
nodejs-github-bot merged 1 commit intoAug 21, 2026
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
The merge-commit job used `make -j4`, which skips configure. After node.gyp or generated sources change, that can leave the comparison binary unlinked against new files. `make build-ci` re-runs configure first, matching the base-build step. Assisted-by: Grok Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com>
cursor
Bot
force-pushed
the
cursor/benchmark-ci-merge-build-1677
branch
from
ee2aff2 to
1968cd3
Compare
August 18, 2026 01:38
Copy link
Copy Markdown
Contributor
|
Fast-track has been requested by @anonrig. Please 👍 to approve. |
Sorry, something went wrong.
jasnell
approved these changes
Aug 18, 2026
anonrig
requested review from
Qard,
ShogunPanda,
bengl,
ljharb,
mcollina,
panva and
ruyadorno
August 20, 2026 22:25
mcollina
approved these changes
Aug 21, 2026
mcollina
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
lgtm
Sorry, something went wrong.
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
The merge-commit job used `make -j4`, which skips configure. After node.gyp or generated sources change, that can leave the comparison binary unlinked against new files. `make build-ci` re-runs configure first, matching the base-build step. Assisted-by: Grok Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> PR-URL: #65362 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
aduh95
pushed a commit
that referenced
this pull request
Aug 25, 2026
The merge-commit job used `make -j4`, which skips configure. After node.gyp or generated sources change, that can leave the comparison binary unlinked against new files. `make build-ci` re-runs configure first, matching the base-build step. Assisted-by: Grok Signed-off-by: Yagiz Nizipli <yagiz@nizipli.com> PR-URL: #65362 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The benchmark workflow’s merge-commit rebuild used make -j4, which skips configure. After node.gyp or generated sources change, that can leave the comparison binary unlinked against new files.
This switches that step to make build-ci -j4 V=1, matching the base-build job.
Standalone CI fix; not part of #65273.