test: remove hidden use of common.PORT in parallel tests · nodejs/node@fe9d9f7 · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit fe9d9f7

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

MylesBorins

committed

test: remove hidden use of common.PORT in parallel tests

common.hasMultiLocalhost() uses common.PORT under the hood. This is problematic in parallel tests because another test using port 0 to get an arbitrary open port may end up getting common.PORT before the test using common.PORT gets it. Therefore, change common.PORT to port 0 in common.hasMultiLocalhost(). PR-URL: #17466 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jon Moss <me@jonathanmoss.me> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

1 parent f7b0054 commit fe9d9f7
Copy full SHA for fe9d9f7

1 file changed

+1-1Lines changed: 1 addition & 1 deletion

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• test/common
  • index.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎test/common/index.js‎

Copy file name to clipboardExpand all lines: test/common/index.js

+1-1Lines changed: 1 addition & 1 deletion

Original file line number	Diff line number	Diff line change
@@ -526,7 +526,7 @@ function _mustCallInner(fn, criteria = 1, field) {
526	526	exports.hasMultiLocalhost = function hasMultiLocalhost() {
527	527	const { TCP, constants: TCPConstants } = process.binding('tcp_wrap');
528	528	const t = new TCP(TCPConstants.SOCKET);
529		- const ret = t.bind('127.0.0.2', exports.PORT);
	529	+ const ret = t.bind('127.0.0.2', 0);
530	530	t.close();
531	531	return ret === 0;
532	532	};

0 commit comments

Comments

0 (0)