doc: remove "note that" from writing-and-running-benchmarks.md · nodejs/node@ffba80b · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 633
• Pull requests 759
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit ffba80b

Browse filesBrowse the repository at this point in the historyBrowse files

Trott

authored and

targos

committed

doc: remove "note that" from writing-and-running-benchmarks.md

Refs: nodejs/remark-preset-lint-node#16 PR-URL: #28329 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

1 parent 1591309 commit ffba80b
Copy full SHA for ffba80b

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• doc/guides
  • writing-and-running-benchmarks.md

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎doc/guides/writing-and-running-benchmarks.md‎

Copy file name to clipboardExpand all lines: doc/guides/writing-and-running-benchmarks.md

+2-2Lines changed: 2 additions & 2 deletions

• Display the source diff
• Display the rich diff

Original file line number	Diff line number	Diff line change
@@ -352,7 +352,7 @@ The arguments of `createBenchmark` are:
352	352	* `configs` {Object} The benchmark parameters. `createBenchmark` will run all
353	353	possible combinations of these parameters, unless specified otherwise.
354	354	Each configuration is a property with an array of possible values.
355		- Note that the configuration values can only be strings or numbers.
	355	+ The configuration values can only be strings or numbers.
356	356	* `options` {Object} The benchmark options. At the moment only the `flags`
357	357	option for specifying command line flags is supported.
358	358
@@ -400,7 +400,7 @@ const options = {
400	400	// `main` and `configs` are required, `options` is optional.
401	401	const bench = common.createBenchmark(main, configs, options);
402	402
403		- // Note that any code outside main will be run twice,
	403	+ // Any code outside main will be run twice,
404	404	// in different processes, with different command line arguments.
405	405
406	406	function main(conf) {

0 commit comments

Comments

0 (0)