Commit fff1e7f
src: fix abort on uv_loop_init() failure
Fixes: #34855
PR-URL: #34874
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>1 parent 7666d95 commit fff1e7f
1 file changed
Lines changed: 9 additions & 1 deletion
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
@@ -457,9 +457,17 @@ Maybe<bool> SyncProcessRunner::TryInitializeAndRunLoop(Local<Value> options) { | |||
| 457 | 457 | SetError(UV_ENOMEM); | |
| 458 | 458 | return Just(false); | |
| 459 | 459 | } | |
| 460 | - CHECK_EQ(uv_loop_init(uv_loop_), 0); | ||
| 460 | + | ||
| 461 | + r = uv_loop_init(uv_loop_); | ||
| 462 | + if (r < 0) { | ||
| 463 | + delete uv_loop_; | ||
| 464 | + uv_loop_ = nullptr; | ||
| 465 | + SetError(r); | ||
| 466 | + return Just(false); | ||
| 467 | + } | ||
| 461 | 468 | ||
| 462 | 469 | if (!ParseOptions(options).To(&r)) return Nothing<bool>(); | |
| 470 | + | ||
| 463 | 471 | if (r < 0) { | |
| 464 | 472 | SetError(r); | |
| 465 | 473 | return Just(false); | |
0 commit comments