FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src: fix abort on uv_loop_init() failure by bnoordhuis · Pull Request #34874 · nodejs/node · GitHub

/ node Public

src: fix abort on uv_loop_init() failure - #34874

Closed
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:fix34855
ConversationCommits (1)ChecksFiles changed
Closed

src: fix abort on uv_loop_init() failure#34874
bnoordhuis wants to merge 1 commit into
nodejs:masterfrom
bnoordhuis:fix34855

Conversation

bnoordhuis commented Aug 22, 2020

Copy link
Copy Markdown
Member

Fixes: #34855

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem. labels Aug 22, 2020
bnoordhuis mentioned this pull request Aug 22, 2020
Closed
lundibundi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 22, 2020

nodejs-github-bot commented Aug 22, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32889/

Trott commented Aug 24, 2020

Copy link
Copy Markdown
Member

Landed in b8ab49f

Trott closed this Aug 24, 2020
Trott pushed a commit that referenced this pull request Aug 24, 2020
src: fix abort on uv_loop_init() failure
b8ab49f 
Fixes: #34855

PR-URL: #34874
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Aug 25, 2020
src: fix abort on uv_loop_init() failure
fff1e7f 
Fixes: #34855

PR-URL: #34874
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams mentioned this pull request Aug 25, 2020
Merged
addaleax pushed a commit that referenced this pull request Sep 22, 2020
src: fix abort on uv_loop_init() failure
d0481d1 
Fixes: #34855

PR-URL: #34874
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
src: fix abort on uv_loop_init() failure
26a596b 
Fixes: #34855

PR-URL: #34874
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Denys Otrishko <shishugi@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere mentioned this pull request Sep 28, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
cjihrig cjihrig approved these changes
gireeshpunathil gireeshpunathil approved these changes
+1 more reviewer
lundibundi lundibundi approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. child_process Issues and PRs related to the child_process subsystem.

Projects

None yet

Milestone

No milestone

6 participants

Back | FazBrowse Home | New Git URL