errors: use `ErrorPrototypeToString` from `primordials` object · nodejs/node@fffba3a · GitHub

nodejs / node Public

• Notifications You must be signed in to change notification settings
• Fork 36.6k
• Star 120k

• Code
• Issues 635
• Pull requests 755
• Actions
• Projects
• Security and quality
• Insights

Additional navigation options

Commit fffba3a

Browse filesBrowse the repository at this point in the historyBrowse files

ExE-Boss

authored and

richardlau

committed

errors: use ErrorPrototypeToString from primordials object

PR-URL: #34891 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

1 parent be71e71 commit fffba3a
Copy full SHA for fffba3a

1 file changed

+2-2Lines changed: 2 additions & 2 deletions

File tree

Expand file treeCollapse file tree

Open diff view settings

Filter options

• lib/internal
  • errors.js

Expand file treeCollapse file tree

Open diff view settings

Collapse file

‎lib/internal/errors.js‎

Copy file name to clipboardExpand all lines: lib/internal/errors.js

+2-2Lines changed: 2 additions & 2 deletions

Original file line number	Diff line number	Diff line change
@@ -13,6 +13,7 @@
13	13	const {
14	14	ArrayIsArray,
15	15	Error,
	16	+ ErrorPrototypeToString,
16	17	JSONStringify,
17	18	Map,
18	19	MathAbs,
@@ -47,7 +48,6 @@ const kTypes = [
47	48	];
48	49
49	50	const MainContextError = Error;
50		- const ErrorToString = Error.prototype.toString;
51	51	const overrideStackTrace = new WeakMap();
52	52	const kNoOverride = Symbol('kNoOverride');
53	53	const prepareStackTrace = (globalThis, error, trace) => {
@@ -68,7 +68,7 @@ const prepareStackTrace = (globalThis, error, trace) => {
68	68	// Error: Message
69	69	// at function (file)
70	70	// at file
71		- const errorString = ErrorToString.call(error);
	71	+ const errorString = ErrorPrototypeToString(error);
72	72	if (trace.length === 0) {
73	73	return errorString;
74	74	}

0 commit comments

Comments

0 (0)