errors: use `ErrorPrototypeToString` from `primordials` object by ExE-Boss · Pull Request #34891 · nodejs/node · GitHub

This ensures that the prepareStackTrace no override fallback path doesn’t get broken by Error.prototype.toString.call not being Function.prototype.call.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

CI: https://ci.nodejs.org/job/node-test-pull-request/32907/

Commit Queue failed

- Loading data for nodejs/node/pull/34891 ✔ Done loading data for nodejs/node/pull/34891 ----------------------------------- PR info ------------------------------------ Title errors: Use `ErrorPrototypeToString` from `primordials` object (#34891) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch ExE-Boss:lib/internal/errors/use-primordials-error-prototype-tostring -> nodejs:master Labels errors Commits 1 - errors: Use `ErrorPrototypeToString` from `primordials` object Committers 1 - ExE Boss <3889017+ExE-Boss@users.noreply.github.com> PR-URL: https://github.com/nodejs/node/pull/34891 Reviewed-By: Gus Caplan Reviewed-By: Michaël Zasso Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/34891 Reviewed-By: Gus Caplan Reviewed-By: Michaël Zasso Reviewed-By: Ruben Bridgewater Reviewed-By: James M Snell Reviewed-By: Luigi Pinca Reviewed-By: Colin Ihrig -------------------------------------------------------------------------------- ℹ Last Full PR CI on 2020-08-23T17:41:17Z: https://ci.nodejs.org/job/node-test-pull-request/32907/ - Querying data of job/node-test-pull-request/32907/ ✔ Build data downloaded ℹ This PR was created on Sun, 23 Aug 2020 15:45:55 GMT ✔ Approvals: 6 ✔ - Gus Caplan (@devsnek): https://github.com/nodejs/node/pull/34891#pullrequestreview-473024249 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/34891#pullrequestreview-473024251 ✔ - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/34891#pullrequestreview-473026575 ✔ - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/34891#pullrequestreview-473596914 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/34891#pullrequestreview-473794806 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/34891#pullrequestreview-474025385 -------------------------------------------------------------------------------- ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 34891 ✔ Downloaded patch to /home/runner/work/node/node/.ncu/34891/patch -------------------------------------------------------------------------------- Applying: errors: Use `ErrorPrototypeToString` from `primordials` object ✔ Patches applied -------------------------------------------------------------------------------- --------------------------------- New Message ---------------------------------- errors: Use `ErrorPrototypeToString` from `primordials` object

PR-URL: #34891
Reviewed-By: Gus Caplan me@gus.host
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com

[master 7235e929] errors: Use ErrorPrototypeToString from primordials object
Author: ExE Boss 3889017+ExE-Boss@users.noreply.github.com
Date: Sun Aug 23 17:40:00 2020 +0200
1 file changed, 2 insertions(+), 2 deletions(-)
✖ 7235e92928995d37b42429997e6b785de572805b
✔ 0:0 skipping fixes-url fixes-url
✔ 0:0 blank line after title line-after-title
✔ 0:0 line-lengths are valid line-length
✔ 0:0 metadata is at end of message metadata-end
✔ 1:8 PR-URL is valid. pr-url
✔ 0:0 reviewers are valid reviewers
✔ 0:0 valid subsystems subsystem
✖ 0:9 First word after subsystem(s) in title should be lowercase. title-format
⚠ 0:50 Title should be <= 50 columns. title-length

ℹ Please fix the commit message and try again.

LGTM if the commit queue bot is OK with the commit message.

CI: https://ci.nodejs.org/job/node-test-pull-request/32931/

Landed in 565d993

PR-URL: #34891 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

This should probably also be backported.

PR-URL: #34891 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

nodejs-github-bot added the errors Issues and PRs related to JavaScript errors originated in Node.js core. label Aug 23, 2020

devsnek approved these changes Aug 23, 2020

View reviewed changes

targos approved these changes Aug 23, 2020

View reviewed changes

BridgeAR approved these changes Aug 23, 2020

View reviewed changes

jasnell approved these changes Aug 24, 2020

View reviewed changes

lpinca approved these changes Aug 24, 2020

View reviewed changes

cjihrig approved these changes Aug 25, 2020

View reviewed changes

devsnek added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 25, 2020

github-actions Bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Aug 25, 2020

ExE-Boss changed the title errors: Use ErrorPrototypeToString from primordials object errors: use ErrorPrototypeToString from primordials object Aug 25, 2020

ExE-Boss force-pushed the lib/internal/errors/use-primordials-error-prototype-tostring branch from c38afbb to 1df8048 Compare August 25, 2020 22:31

errors: use ErrorPrototypeToString from primordials object

1df8048

ExE-Boss requested review from BridgeAR, cjihrig, devsnek, jasnell, lpinca and targos August 25, 2020 22:33

cjihrig approved these changes Aug 25, 2020

View reviewed changes

devsnek approved these changes Aug 26, 2020

View reviewed changes

devsnek added request-ci Add this label to start a Jenkins CI on a PR. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Aug 26, 2020

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 26, 2020

devsnek added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 26, 2020

github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 26, 2020

github-actions Bot closed this Aug 26, 2020

ExE-Boss deleted the lib/internal/errors/use-primordials-error-prototype-tostring branch August 26, 2020 14:01

richardlau mentioned this pull request Sep 2, 2020

v14.10.0 proposal #35023

Merged

4 tasks

codebytere mentioned this pull request Sep 28, 2020

v12.19.0 proposal #35401

Merged

errors: use `ErrorPrototypeToString` from `primordials` object by ExE-Boss · Pull Request #34891 · nodejs/node · GitHub

Uh oh!

Uh oh!

errors: use ErrorPrototypeToString from primordials object - #34891

errors: use ErrorPrototypeToString from primordials object#34891
ExE-Boss wants to merge 1 commit into
nodejs:masterfrom
ExE-Boss:lib/internal/errors/use-primordials-error-prototype-tostring

ExE-Boss commented Aug 23, 2020

Uh oh!

nodejs-github-bot commented Aug 23, 2020

Uh oh!

github-actions Bot commented Aug 25, 2020

Uh oh!

cjihrig left a comment

Uh oh!

nodejs-github-bot commented Aug 26, 2020

Uh oh!

github-actions Bot commented Aug 26, 2020

Uh oh!

ExE-Boss commented Aug 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

errors: use `ErrorPrototypeToString` from `primordials` object by ExE-Boss · Pull Request #34891 · nodejs/node · GitHub

Uh oh!

Uh oh!

errors: use ErrorPrototypeToString from primordials object - #34891

Conversation

ExE-Boss commented Aug 23, 2020

Checklist

Uh oh!

nodejs-github-bot commented Aug 23, 2020

Uh oh!

github-actions Bot commented Aug 25, 2020

PR-URL: #34891 Reviewed-By: Gus Caplan me@gus.host Reviewed-By: Michaël Zasso targos@protonmail.com Reviewed-By: Ruben Bridgewater ruben@bridgewater.de Reviewed-By: James M Snell jasnell@gmail.com Reviewed-By: Luigi Pinca luigipinca@gmail.com Reviewed-By: Colin Ihrig cjihrig@gmail.com

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

nodejs-github-bot commented Aug 26, 2020

Uh oh!

github-actions Bot commented Aug 26, 2020

Uh oh!

ExE-Boss commented Aug 26, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

PR-URL: #34891
Reviewed-By: Gus Caplan me@gus.host
Reviewed-By: Michaël Zasso targos@protonmail.com
Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
Reviewed-By: James M Snell jasnell@gmail.com
Reviewed-By: Luigi Pinca luigipinca@gmail.com
Reviewed-By: Colin Ihrig cjihrig@gmail.com