| FazBrowse GitHub Viewer | Trending | | Home |
| Tools: [Download Repo ZIP] [Original HTTPS Page] |
Sorry, something went wrong.
quic support doesn't exist prior to Node.js 15 and is unlikely to due to requiring patches on top of openssl. Remove the entries from CODEOWNERS to fix the CODEOWNERS linting, which currently fails as it refers to non-existent paths. PR-URL: #34947 Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Avoid repeating too much from the Microsoft guide by providing links to it. PR-URL: #34871 Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #34881 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Refs: https://docs.microsoft.com/en-us/style-guide/a-z-word-list-term-collections/a/above PR-URL: #34877 Reviewed-By: Jan Krems <jan.krems@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
This adds a new make target to generate platform dependent files for openssl on non-linux machines. The scripts we currently have in place require linux. This adds a Dockerfile that installs the necessary dependencies to be able to generate these files. Previously, it was necessary to run `make -C deps/openssl/config` on a linux machine. Now, as long as docker is installed and in your `PATH`, it is possible to run `make gen-openssl`. PR-URL: #34642 Reviewed-By: James M Snell <jasnell@gmail.com>
This adds the required files for supporting openssl on arm64. This uses the same configuration that can be found in openssl/openssl#12369 to generate the required files. PR-URL: #34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
Ref: nodejs/TSC#886 Ref: #34043 PR-URL: #34238 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ash Cripps <ashley.cripps@ibm.com>
PR-URL: #34889 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: Daijiro Wachi <daijiro.wachi@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Gus Caplan <me@gus.host>
PR-URL: #34891 Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
The `<` character is interpreted as the start of an HTML tag, making the word `address` not render and the rest of the document rendered with a grey background and in italics. Use `<` instead. PR-URL: #34892 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Minor improvements. PR-URL: #34868 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
The _name_ attribute is obsolete. Changing it to _id_ in the case of "toc" would result in a conflict with an existing id. However, there are no links to "#toc" in our docs. And if there were, it would be more appropriate to link to the id toc which is the toc for the individual documents. So remove the anchor name entirely. PR-URL: #34893 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
PR-URL: #34879 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #34897 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: David Carlier <devnexen@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #34880 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #34552 Reviewed-By: James M Snell <jasnell@gmail.com>
Most of the instances of _node-addon-api_ are surrounded with backticks, but two aren't. Add backticks for consistency. PR-URL: #34910 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
PR-URL: #34909 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
PR-URL: #34923 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
* Avoid passing core `void*` and function pointers into add-on. * Document `napi_async_cleanup_hook_handle` type. * Render receipt of the handle mandatory from the point where the hook gets called. Removal of the handle remains mandatory. Fixes: #34715 Signed-off-by: Gabriel Schulhof <gabriel.schulhof@intel.com> Co-authored-by: Anna Henningsen <github@addaleax.net> PR-URL: #34819 Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
PR-URL: #34926 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
PR-URL: #34861 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Refs: https://github.com/google/brotli/releases/tag/v1.0.8 Refs: https://github.com/google/brotli/releases/tag/v1.0.9 PR-URL: #34937 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
PR-URL: #34943 Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Evan Lucas <evanlucas@me.com>
Use uv_metrics_idle_time() to return a high resolution millisecond timer of the amount of time the event loop has been idle since it was initialized. Include performance.eventLoopUtilization() API to handle the math of calculating the idle and active times. This has been added to prevent accidental miscalculations of the event loop utilization. Such as not taking into consideration offsetting nodeTiming.loopStart or timing differences when being called from a Worker thread. PR-URL: #34938 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Adrian Estrada <edsadr@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Stephen Belanger <admin@stephenbelanger.com> Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com> Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
PR-URL: #34929 Reviewed-By: Denys Otrishko <shishugi@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Start up a TLS server on localhost rather than using example.org. PR-URL: #34953 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sorry, something went wrong.
bash-4.2$ ncu-ci citgm 2458 2459 -------------------------------------------------------------------------------- [1/1] Running CITGM: 2458 -------------------------------------------------------------------------------- ✔ Summary data downloaded ✔ Results data downloaded ✔ Summary data downloaded ✔ Results data downloaded ----------------------------------- Summary ------------------------------------ Result FAILURE URL https://ci.nodejs.org/job/citgm-smoker/2458/ Source https://api.github.com/repos/nodejs/node/git/refs/heads/v14.x Commit [72ce09db22f5] Working on v14.9.1 Date 2020-08-27 15:38:44 +0100 Author Bethany.Griggs <Bethany.Griggs@uk.ibm.com> ----------------------------------- Summary ------------------------------------ Result FAILURE URL https://ci.nodejs.org/job/citgm-smoker/2459/ Source https://api.github.com/repos/nodejs/node/git/refs/heads/v14.10.0-proposal Commit [ce5f5877c250] 2020-09-08, Version 14.10.0 (Current) Date 2020-09-07 12:37:51 -0400 Author Richard Lau <riclau@uk.ibm.com> ----------------------------------- Results ------------------------------------ FAILURE: 3 failures in 2459 not present in 2458 ┌────────────────────────┬─────────────────────────┐ │ (index) │ 0 │ ├────────────────────────┼─────────────────────────┤ │ osx1014 │ 'q-v1.5.1' │ │ rhel7-s390x │ 'torrent-stream-v1.2.0' │ │ fedora-last-latest-x64 │ 'torrent-stream-v1.2.0' │ │ ubuntu1804-64 │ │ │ osx1015 │ │ │ debian9-64 │ │ │ fedora-latest-x64 │ │ │ centos7-ppcle │ │ │ ubuntu1604-64 │ │ └────────────────────────┴─────────────────────────┘ bash-4.2$ Not shown here is that eslint-plugin-jest failed in both CITGM runs across multiple platforms. I've raised nodejs/citgm#824 -- the module has switched to using yarn 2 which is incompatible with an option CITGM passes through. In any case this looks like an issue with CITGM and the new version of that module rather than something in this release. The torrent-stream failures are the same as seen on the CITGM run against v14.x on other platforms. The q failure is a timeout seen on osx1014. It didn't fail on osx1015. I've started another CITGM run, https://ci.nodejs.org/job/citgm-smoker/2460/, but at the moment I'm not too concerned about this failure. |
Sorry, something went wrong.
Sorry, something went wrong.
|
Were there new failures in 14.9 on Citgm? I don't recognize the browserify failures for example |
Sorry, something went wrong.
|
@MylesBorins, just briefly dug into the Browserify failures. It seems to be occurring as far back as v14.0.0 and also on v12.x. |
Sorry, something went wrong.
Notable changes: - buffer: also alias BigUInt methods (Anna Henningsen) #34960 - crypto: add randomInt function (Oli Lalonde) #34600 - perf_hooks: add idleTime and event loop util (Trevor Norris) #34938 - stream: simpler and faster Readable async iterator (Robert Nagy) #34035 - stream: save error in state (Robert Nagy) #34103 PR-URL: #35023 Conflicts: src/node_version.h
Notable changes: - buffer: also alias BigUInt methods (Anna Henningsen) nodejs#34960 - crypto: add randomInt function (Oli Lalonde) nodejs#34600 - perf_hooks: add idleTime and event loop util (Trevor Norris) nodejs#34938 - stream: simpler and faster Readable async iterator (Robert Nagy) nodejs#34035 - stream: save error in state (Robert Nagy) nodejs#34103 PR-URL: nodejs#35023 Conflicts: src/node_version.h
| Back | FazBrowse Home | New Git URL |
2020-09-08, Version 14.10.0 (Current), @richardlau
Notable Changes
Commits
cc @nodejs/release
Checklist