doc use consistent typography for node-addon-api - #34910
Merged
Trott merged 1 commit intoAug 27, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Collaborator
|
Review requested:
|
Sorry, something went wrong.
lpinca
approved these changes
Aug 25, 2020
NickNaso
approved these changes
Aug 25, 2020
NickNaso
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
addaleax
approved these changes
Aug 26, 2020
Most of the instances of _node-addon-api_ are surrounded with backticks, but two aren't. Add backticks for consistency. PR-URL: nodejs#34910 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau
pushed a commit
that referenced
this pull request
Sep 1, 2020
Most of the instances of _node-addon-api_ are surrounded with backticks, but two aren't. Add backticks for consistency. PR-URL: #34910 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Most of the instances of _node-addon-api_ are surrounded with backticks, but two aren't. Add backticks for consistency. PR-URL: #34910 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Most of the instances of _node-addon-api_ are surrounded with backticks, but two aren't. Add backticks for consistency. PR-URL: #34910 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Most of the instances of node-addon-api are surrounded with backticks,
but two aren't. Add backticks for consistency.
Checklist