FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tools: add banner to lint-md.js by rollup.config.js by KuthorX · Pull Request #34233 · nodejs/node · GitHub

/ node Public

tools: add banner to lint-md.js by rollup.config.js - #34233

Merged
Trott merged 1 commit into
nodejs:masterfrom
KuthorX:add-lint-md-banner
Sep 4, 2020
ConversationCommits (1)ChecksFiles changed
Merged

tools: add banner to lint-md.js by rollup.config.js#34233
Trott merged 1 commit into
nodejs:masterfrom
KuthorX:add-lint-md-banner

Conversation

KuthorX commented Jul 7, 2020

Copy link
Copy Markdown
Contributor

To avoid someone like me make a mistake in #34218 , rollup.config.js is added a plugin to append a banner on the top of lint-md.js

Checklist

nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jul 7, 2020
KuthorX mentioned this pull request Jul 7, 2020
Closed
2 tasks

KuthorX commented Jul 7, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

This branch need update...I accidentally add other commit...

  • update branch

Trott commented Jul 7, 2020

Copy link
Copy Markdown
Member

If you run make lint-md-rollup, it should generate the file with the banner. You can test that it still works as expected with make lint-md. If everything comes up OK, then maybe commit that generated version in a second commit on this branch?

KuthorX commented Jul 7, 2020

Copy link
Copy Markdown
Contributor Author

thanks @Trott , the generated lint-md.js is commited

KuthorX commented Sep 4, 2020

Copy link
Copy Markdown
Contributor Author

This pr has been approved but hasn't been merged, could someone merge it or comment to make me improve it?

Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2020

Trott commented Sep 4, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

This pr has been approved but hasn't been merged, could someone merge it or comment to make me improve it?

Will run a CI to make sure there aren't any weird surprises. Assuming that goes well, I'll land it. Thanks for your patience!

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 4, 2020

This comment has been minimized.

Sign in to view

nodejs-github-bot commented Sep 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33053/

tools: add banner to lint-md.js by rollup.config.js
27cf6f7 
PR-URL: #34233
Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott commented Sep 4, 2020

Copy link
Copy Markdown
Member

Landed in 27cf6f7.

Thanks for your patience and thanks for the contribution! 🎉

Trott merged commit 27cf6f7 into nodejs:master Sep 4, 2020
richardlau pushed a commit that referenced this pull request Sep 7, 2020
tools: add banner to lint-md.js by rollup.config.js
b7ea8ff 
PR-URL: #34233
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau mentioned this pull request Sep 7, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
tools: add banner to lint-md.js by rollup.config.js
3d41ff2 
PR-URL: #34233
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
tools: add banner to lint-md.js by rollup.config.js
3e91519 
PR-URL: #34233
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
tools: add banner to lint-md.js by rollup.config.js
1dce35d 
PR-URL: #34233
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
tools: add banner to lint-md.js by rollup.config.js
2e5a797 
PR-URL: nodejs#34233
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes

Assignees

No one assigned

Labels

tools Issues and PRs related to the tools directory.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

Back | FazBrowse Home | New Git URL