test: make .out checks embedder-friendly - #35040
Merged
Trott merged 1 commit intoSep 5, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
richardlau
approved these changes
Sep 3, 2020
cjihrig
approved these changes
Sep 3, 2020
codebytere
force-pushed
the
embedder-agnostic-tests
branch
2 times, most recently
from
13b4d93 to
5f5d473
Compare
September 3, 2020 21:07
Copy link
Copy Markdown
Collaborator
|
CI: https://ci.nodejs.org/job/node-test-pull-request/33058/ (:green_heart:) |
Sorry, something went wrong.
addaleax
approved these changes
Sep 5, 2020
Trott
approved these changes
Sep 5, 2020
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
It's too bad there's no way to do something like path.basename(process.execPath) within the out files. (Or is there?) LGTM.
Sorry, something went wrong.
Trott
force-pushed
the
embedder-agnostic-tests
branch
from
5f5d473 to
3268a9f
Compare
September 5, 2020 20:37
PR-URL: nodejs#35040 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
Copy link
Copy Markdown
Member
We could tell the test runner to replace a specific string, e.g. <execname>, in the expected output file with the value we want to see 🤷♀️ |
Sorry, something went wrong.
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
PR-URL: #35040 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
PR-URL: #35040 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 21, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 21, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 21, 2020
codebytere
added a commit
to electron/electron
that referenced
this pull request
Sep 21, 2020
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#35040 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some of the color support tests in pseudo-tty and some esm tests in message were hardcoded to check the output messages against node - this causes failures in Electron's smoke tests against Node.js, since they'll output e.g:
(Use `electron --trace-warnings ...` to show where the warning was created)in our case.
Checklist