tools,doc: remove "toc" anchor name - #34893
Merged
Trott merged 1 commit intoAug 26, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@nodejs/website |
Sorry, something went wrong.
aymen94
approved these changes
Aug 24, 2020
benjamingr
approved these changes
Aug 24, 2020
This comment has been minimized.
jasnell
approved these changes
Aug 24, 2020
nschonni
approved these changes
Aug 24, 2020
lpinca
approved these changes
Aug 24, 2020
fhinkel
approved these changes
Aug 24, 2020
11 tasks
trivikr
approved these changes
Aug 25, 2020
bnb
approved these changes
Aug 25, 2020
9 tasks
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
The _name_ attribute is obsolete. Changing it to _id_ in the case of "toc" would result in a conflict with an existing id. However, there are no links to "#toc" in our docs. And if there were, it would be more appropriate to link to the id toc which is the toc for the individual documents. So remove the anchor name entirely. PR-URL: nodejs#34893 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
10 tasks
richardlau
pushed a commit
that referenced
this pull request
Sep 1, 2020
The _name_ attribute is obsolete. Changing it to _id_ in the case of "toc" would result in a conflict with an existing id. However, there are no links to "#toc" in our docs. And if there were, it would be more appropriate to link to the id toc which is the toc for the individual documents. So remove the anchor name entirely. PR-URL: #34893 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
The _name_ attribute is obsolete. Changing it to _id_ in the case of "toc" would result in a conflict with an existing id. However, there are no links to "#toc" in our docs. And if there were, it would be more appropriate to link to the id toc which is the toc for the individual documents. So remove the anchor name entirely. PR-URL: #34893 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
The _name_ attribute is obsolete. Changing it to _id_ in the case of "toc" would result in a conflict with an existing id. However, there are no links to "#toc" in our docs. And if there were, it would be more appropriate to link to the id toc which is the toc for the individual documents. So remove the anchor name entirely. PR-URL: #34893 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The name attribute is obsolete. Changing it to id in the case of
"toc" would result in a conflict with an existing id. However, there are
no links to "#toc" in our docs. And if there were, it would be more
appropriate to link to the id toc which is the toc for the individual
documents. So remove the anchor name entirely.
Checklist