FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src,doc: rephrase for clarity by wjabbour · Pull Request #34879 · nodejs/node · GitHub

/ node Public

src,doc: rephrase for clarity - #34879

Closed
wjabbour wants to merge 1 commit into
nodejs:masterfrom
wjabbour:rephrase-line
Closed

src,doc: rephrase for clarity#34879
wjabbour wants to merge 1 commit into
nodejs:masterfrom
wjabbour:rephrase-line

Conversation

Copy link
Copy Markdown
Contributor
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]

Fixed small grammatical error and rephrased line to match small convention used throughout file of introducing new concept then 'Typical ways of working with {new concept}'

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 22, 2020

Copy link
Copy Markdown
Member

Landed in 9ded294, thanks for the PR! :)

addaleax pushed a commit that referenced this pull request Aug 26, 2020
PR-URL: #34879
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax closed this Aug 26, 2020
richardlau pushed a commit that referenced this pull request Sep 1, 2020
PR-URL: #34879
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau mentioned this pull request Sep 2, 2020
4 tasks
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34879
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
PR-URL: #34879
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
wjabbour deleted the rephrase-line branch September 28, 2020 02:55
codebytere mentioned this pull request Sep 28, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants


Back | FazBrowse Home | New Git URL