FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: remove style for empty links by aduh95 · Pull Request #35034 · nodejs/node · GitHub

/ node Public

doc: remove style for empty links - #35034

Merged
Trott merged 1 commit into
nodejs:masterfrom
aduh95:fix-doc-empty-links
Sep 5, 2020
ConversationCommits (1)ChecksFiles changed
Merged

doc: remove style for empty links#35034
Trott merged 1 commit into
nodejs:masterfrom
aduh95:fix-doc-empty-links

Conversation

aduh95 commented Sep 3, 2020 •
edited
Loading

Copy link
Copy Markdown
Contributor

Fix the side effect when hovering over empty anchor links:

It appears on a few pages:

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

Refs: #34955

nodejs-github-bot added the doc Issues and PRs related to the documentations. label Sep 3, 2020

aduh95 commented Sep 4, 2020

Copy link
Copy Markdown
Contributor Author

/cc @Trott as you are the one who suggested this.

Trott commented Sep 4, 2020

Copy link
Copy Markdown
Member

I imagine this may not be an issue now that the <a name="DEPxxxx"></a> links are removed, but not a bad idea to do it anyway.

DerekNonGeneric approved these changes Sep 4, 2020
View reviewed changes

DerekNonGeneric left a comment •
edited
Loading

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Oh dear the anti-pattern exists elsewhere. For the error codes I think we can use a regular expression for if the heading starts with ERR, but in the meantime, you're right about needing this to be corrected.

Trott force-pushed the fix-doc-empty-links branch from d543696 to ec5958f Compare September 5, 2020 20:56

Trott commented Sep 5, 2020

Copy link
Copy Markdown
Member

Landed in ec5958f

doc: remove style for empty links
ec5958f 
PR-URL: nodejs#35034
Refs: nodejs#34955
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Trott merged commit ec5958f into nodejs:master Sep 5, 2020
aduh95 deleted the fix-doc-empty-links branch September 5, 2020 22:06
richardlau pushed a commit that referenced this pull request Sep 7, 2020
doc: remove style for empty links
8bbcc3e 
PR-URL: #35034
Refs: #34955
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
richardlau mentioned this pull request Sep 7, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
doc: remove style for empty links
28e89f6 
PR-URL: #35034
Refs: #34955
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
mscdex mentioned this pull request Sep 8, 2020
Closed

Trott commented Sep 8, 2020

Copy link
Copy Markdown
Member

Alas, this causes visited links to show in a different color.

Revert since we're eliminating <a name="foo"></a> tags anyway? Or add a:visited to the stylesheet?

@nodejs/website

Trott commented Sep 8, 2020

Copy link
Copy Markdown
Member

#35108

addaleax pushed a commit that referenced this pull request Sep 22, 2020
doc: remove style for empty links
8514ce0 
PR-URL: #35034
Refs: #34955
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
doc: remove style for empty links
1ce26fe 
PR-URL: #35034
Refs: #34955
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
doc: remove style for empty links
e9ecde6 
PR-URL: nodejs#35034
Refs: nodejs#34955
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
+1 more reviewer
DerekNonGeneric DerekNonGeneric approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

Back | FazBrowse Home | New Git URL