FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

querystring: manage percent character at unescape by watilde · Pull Request #35013 · nodejs/node · GitHub

/ node Public

querystring: manage percent character at unescape - #35013

Merged
Trott merged 1 commit into
nodejs:masterfrom
watilde:fixes-35012
Sep 4, 2020
ConversationCommits (1)ChecksFiles changed
Merged

querystring: manage percent character at unescape#35013
Trott merged 1 commit into
nodejs:masterfrom
watilde:fixes-35012

Conversation

watilde commented Sep 1, 2020

Copy link
Copy Markdown
Member

Related: #33892
Fixes: #35012

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines

watilde added the querystring Issues and PRs related to the built-in querystring module. label Sep 1, 2020
watilde mentioned this pull request Sep 2, 2020
Closed
watilde added the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 2, 2020

nodejs-github-bot commented Sep 2, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32997/

watilde requested a review from joyeecheung September 2, 2020 07:57

nodejs-github-bot commented Sep 4, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/33045/

querystring: manage percent character at unescape
3b92521 
Related: nodejs#33892
Fixes: nodejs#35012

PR-URL: nodejs#35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Trott commented Sep 4, 2020

Copy link
Copy Markdown
Member

Landed in 3b92521

Trott merged commit 3b92521 into nodejs:master Sep 4, 2020
watilde deleted the fixes-35012 branch September 4, 2020 03:58

watilde commented Sep 4, 2020

Copy link
Copy Markdown
Member Author

Thank you

watilde added a commit to watilde/node that referenced this pull request Sep 4, 2020
test: update WPT tests of URL for URLSearchParams parsing %
73eb5e1 
Related: web-platform-tests/wpt#24152
Related: nodejs#35013
Fixes: nodejs#33892
richardlau pushed a commit that referenced this pull request Sep 7, 2020
querystring: manage percent character at unescape
3367613 
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau mentioned this pull request Sep 7, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
querystring: manage percent character at unescape
1bf5d1a 
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
watilde mentioned this pull request Sep 8, 2020
Closed
addaleax pushed a commit that referenced this pull request Sep 22, 2020
querystring: manage percent character at unescape
bde9fb8 
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
querystring: manage percent character at unescape
6ccacdf 
Related: #33892
Fixes: #35012

PR-URL: #35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
codebytere mentioned this pull request Sep 28, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
querystring: manage percent character at unescape
5366a2c 
Related: nodejs#33892
Fixes: nodejs#35012

PR-URL: nodejs#35013
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Shingo Inoue <leko.noor@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Trott Trott approved these changes
joyeecheung joyeecheung approved these changes
jasnell Awaiting requested review from jasnell
lundibundi Awaiting requested review from lundibundi
+2 more reviewers
Leko Leko approved these changes
yashLadha yashLadha approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

querystring Issues and PRs related to the built-in querystring module.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

querystring.unescape does not correctly unescape percent characters

6 participants

Back | FazBrowse Home | New Git URL