doc: update syntax highlighting color for accessibility - #35063
Merged
Trott merged 1 commit intoSep 6, 2020
Merged
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
Before:
After:
|
Sorry, something went wrong.
DerekNonGeneric
approved these changes
Sep 5, 2020
DerekNonGeneric
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Yep, you're right.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
@nodejs/website |
Sorry, something went wrong.
lpinca
approved these changes
Sep 6, 2020
MylesBorins
approved these changes
Sep 6, 2020
MylesBorins
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
fast track? |
Sorry, something went wrong.
Previous contrast with background was 3.65, failing WCAG AA. This change brings contrast to 4.50, passing WCAG AA. PR-URL: nodejs#35063 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Trott
force-pushed
the
syntax-contrast
branch
from
009312a to
2b2208e
Compare
September 6, 2020 18:17
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
Previous contrast with background was 3.65, failing WCAG AA. This change brings contrast to 4.50, passing WCAG AA. PR-URL: #35063 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
Previous contrast with background was 3.65, failing WCAG AA. This change brings contrast to 4.50, passing WCAG AA. PR-URL: #35063 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Previous contrast with background was 3.65, failing WCAG AA. This change brings contrast to 4.50, passing WCAG AA. PR-URL: #35063 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Sep 22, 2020
Previous contrast with background was 3.65, failing WCAG AA. This change brings contrast to 4.50, passing WCAG AA. PR-URL: #35063 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Previous contrast with background was 3.65, failing WCAG AA. This change brings contrast to 4.50, passing WCAG AA. PR-URL: nodejs#35063 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previous contrast with background was 3.65, failing WCAG AA. This change
brings contrast to 4.50, passing WCAG AA.
Checklist