FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

src,doc: fix grammar due to missing 'is' by wjabbour · Pull Request #34897 · nodejs/node · GitHub

/ node Public

src,doc: fix grammar due to missing 'is' - #34897

Closed
wjabbour wants to merge 1 commit into
nodejs:masterfrom
wjabbour:grammar-missing-is
Closed

src,doc: fix grammar due to missing 'is'#34897
wjabbour wants to merge 1 commit into
nodejs:masterfrom
wjabbour:grammar-missing-is

Conversation

Copy link
Copy Markdown
Contributor
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows [commit guidelines]

nodejs-github-bot added the c++ Issues and PRs that require attention from people who are familiar with C++. label Aug 24, 2020

wjabbour commented Aug 24, 2020
edited
Loading

Copy link
Copy Markdown
Contributor Author

should've probably read 'static binding_data_name field that is based on a'

addaleax pushed a commit that referenced this pull request Aug 26, 2020
PR-URL: #34897
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Copy link
Copy Markdown
Member

Landed in 0f9650b

addaleax closed this Aug 26, 2020
richardlau pushed a commit that referenced this pull request Sep 1, 2020
PR-URL: #34897
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: David Carlier <devnexen@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau mentioned this pull request Sep 2, 2020
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL