doc: add ESM examples in module API doc page - #34875
Closed
aduh95 wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
aduh95
commented
Aug 22, 2020
Comment thread
doc/api/module.md
Outdated
aduh95
commented
Aug 24, 2020
Comment thread
doc/api/module.md
Outdated
2 tasks
Copy link
Copy Markdown
Contributor
|
/cc @nodejs/modules |
Sorry, something went wrong.
MylesBorins
approved these changes
Sep 1, 2020
MylesBorins
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM
Sorry, something went wrong.
guybedford
approved these changes
Sep 1, 2020
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
PR-URL: #34875 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
richardlau
pushed a commit
that referenced
this pull request
Sep 7, 2020
PR-URL: #34875 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
PR-URL: #34875 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 4, 2020
PR-URL: #34875 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
PR-URL: #34875 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
PR-URL: nodejs#34875 Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Guy Bedford <guybedford@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In an effort to promote ESM usage, add examples using this syntax alongside CJS ones. I've also added some links where it was missing.
Checklist