FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

meta: update module pages in CODEOWNERS by aduh95 · Pull Request #34932 · nodejs/node · GitHub

/ node Public

meta: update module pages in CODEOWNERS - #34932

Closed
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:patch-3
ConversationCommits (1)ChecksFiles changed
Closed

meta: update module pages in CODEOWNERS#34932
aduh95 wants to merge 1 commit into
nodejs:masterfrom
aduh95:patch-3

Conversation

aduh95 commented Aug 26, 2020

Copy link
Copy Markdown
Contributor

I figured that should explain why the bot didn't tag @nodejs/modules in #34875.

Maybe we could add a test to check if every file is listed to the CODEOWNERS to avoid it happening again?

I've also added /doc/api/packages.md, which will be introduced by #34748, it's probably a good idea to wait for it to land first before landing this PR.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

nodejs-github-bot commented Aug 26, 2020 •
edited by richardlau
Loading

Copy link
Copy Markdown
Collaborator

Review requested:

  • @nodejs/tsc

nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Aug 26, 2020

richardlau commented Aug 26, 2020

Copy link
Copy Markdown
Member

I've also added /doc/api/packages.md, which will be introduced by #34748, it's probably a good idea to wait for it to land first before landing this PR.

This will be blocked until that lands as the linting for CODEOWNERS will fail for non-existent paths.

richardlau reviewed Aug 26, 2020
View reviewed changes
Comment thread .github/CODEOWNERS Outdated

mmarchini commented Aug 26, 2020

Copy link
Copy Markdown
Contributor

Maybe we could add a test to check if every file is listed to the CODEOWNERS to avoid it happening again?

This is a good idea once we have all files listed (we're still very far today)

richardlau added the blocked PRs that are blocked by other issues or PRs. label Aug 26, 2020

aduh95 commented Aug 29, 2020

Copy link
Copy Markdown
Contributor Author

@richardlau #34748 has landed, is there something I can do to unblock this PR?

richardlau removed the blocked PRs that are blocked by other issues or PRs. label Aug 29, 2020

richardlau commented Aug 29, 2020

Copy link
Copy Markdown
Member

@richardlau #34748 has landed, is there something I can do to unblock this PR?

Rebase so that it’s picked up — that should get the lint-codeowners check to pass.

MylesBorins approved these changes Aug 31, 2020
View reviewed changes

MylesBorins left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

MylesBorins commented Aug 31, 2020

Copy link
Copy Markdown
Contributor

Landed in 622ea75

MylesBorins pushed a commit that referenced this pull request Aug 31, 2020
meta: update module pages in CODEOWNERS
622ea75 
PR-URL: #34932
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
aduh95 deleted the patch-3 branch September 1, 2020 10:56

aduh95 commented Sep 1, 2020

Copy link
Copy Markdown
Contributor Author

#34875 is not getting much love because @nodejs-github-bot didn't know who to tag. Can someone ping @nodejs/modules over there please?

richardlau commented Sep 1, 2020

Copy link
Copy Markdown
Member

This depends on #34748 (otherwise the CODEOWNER linting breaks) and that has the backport-blocked-v14.x, so I've added the same label here.

addaleax pushed a commit that referenced this pull request Sep 23, 2020
meta: update module pages in CODEOWNERS
d1be44c 
PR-URL: #34932
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
MylesBorins pushed a commit that referenced this pull request Sep 24, 2020
meta: update module pages in CODEOWNERS
ab7d0e9 
PR-URL: #34932
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
codebytere mentioned this pull request Sep 28, 2020
Merged
MylesBorins mentioned this pull request Sep 29, 2020
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

richardlau richardlau approved these changes
+3 more reviewers
MylesBorins MylesBorins approved these changes
mmarchini mmarchini approved these changes
DerekNonGeneric DerekNonGeneric approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

meta Issues and PRs related to the general management of the project.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL