FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: fix malformed hashes in assert.md by Trott · Pull Request #35028 · nodejs/node · GitHub

/ node Public

doc: fix malformed hashes in assert.md - #35028

Merged
Trott merged 1 commit into
nodejs:masterfrom
Trott:hash-fix
Sep 5, 2020
Merged

doc: fix malformed hashes in assert.md#35028
Trott merged 1 commit into
nodejs:masterfrom
Trott:hash-fix

Conversation

Trott commented Sep 3, 2020

Copy link
Copy Markdown
Member

URL hashes cannot contain #. Use hashes for the locations that were
intended.

Checklist

nodejs-github-bot added assert Issues and PRs related to the assert subsystem. doc Issues and PRs related to the documentations. labels Sep 3, 2020

Trott commented Sep 4, 2020

Copy link
Copy Markdown
Member Author

@nodejs/website

tniessen added the author ready PRs that have at least one approval, no outstanding review comments, and a CI started. label Sep 5, 2020
Trott force-pushed the hash-fix branch 2 times, most recently from 994f269 to 16d058d Compare September 5, 2020 13:50
Trott merged commit 16d058d into nodejs:master Sep 5, 2020

Trott commented Sep 5, 2020

Copy link
Copy Markdown
Member Author

Landed in 16d058d

Trott deleted the hash-fix branch September 5, 2020 13:50
URL hashes cannot contain `#`. Use hashes for the locations that were
intended.

PR-URL: nodejs#35028
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau pushed a commit that referenced this pull request Sep 7, 2020
URL hashes cannot contain `#`. Use hashes for the locations that were
intended.

PR-URL: #35028
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
richardlau mentioned this pull request Sep 7, 2020
4 tasks
richardlau pushed a commit that referenced this pull request Sep 7, 2020
URL hashes cannot contain `#`. Use hashes for the locations that were
intended.

PR-URL: #35028
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
URL hashes cannot contain `#`. Use hashes for the locations that were
intended.

PR-URL: #35028
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
addaleax pushed a commit that referenced this pull request Sep 22, 2020
URL hashes cannot contain `#`. Use hashes for the locations that were
intended.

PR-URL: #35028
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
codebytere mentioned this pull request Sep 28, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
URL hashes cannot contain `#`. Use hashes for the locations that were
intended.

PR-URL: nodejs#35028
Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

assert Issues and PRs related to the assert subsystem. author ready PRs that have at least one approval, no outstanding review comments, and a CI started. doc Issues and PRs related to the documentations.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants


Back | FazBrowse Home | New Git URL