tools,doc: fix global table of content active element - #34976
Closed
aduh95 wants to merge 0 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
That doesn't seem to have done it. Providing a screenshot might convince me otherwise, but would you mind double-checking? |
Sorry, something went wrong.
DerekNonGeneric
approved these changes
Aug 29, 2020
DerekNonGeneric
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Nevermind, this does indeed resolve the bug. I had forgotten to rebuild the docs.
Sorry, something went wrong.
himself65
approved these changes
Aug 30, 2020
Copy link
Copy Markdown
Collaborator
Sorry, something went wrong.
Merged
joesepi
pushed a commit
to joesepi/node
that referenced
this pull request
Jan 8, 2021
Assign active class to the correct HTML element when one nav-id is a subset of another one (E.G.: `nav-module` and `nav-modules`). Fixes: nodejs#34975 PR-URL: nodejs#34976 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Zeyu Yang <himself65@outlook.com>
This was referenced Sep 29, 2022
This was referenced Oct 5, 2022
This was referenced Oct 8, 2022
This was referenced Oct 26, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Assign active class to the correct HTML element when one nav-id is a
subset of another one (E.G.: nav-module and nav-modules).
Fixes: #34975
Checklist