FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

stream: fix Readable stream state properties by lundibundi · Pull Request #34886 · nodejs/node · GitHub

/ node Public

stream: fix Readable stream state properties - #34886

Closed
lundibundi wants to merge 2 commits into
nodejs:masterfrom
lundibundi:fix-stream-getter-props
ConversationCommits (2)ChecksFiles changed
Closed

stream: fix Readable stream state properties#34886
lundibundi wants to merge 2 commits into
nodejs:masterfrom
lundibundi:fix-stream-getter-props

Conversation

lundibundi commented Aug 23, 2020

Copy link
Copy Markdown
Member

Looks like they have been accidentally moved in
#31144. This also adds the proxy
properties to Readable since they have been present all this time
and removing them would be breaking.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

/cc @nodejs/streams @antsmartian

lundibundi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020
nodejs-github-bot added the stream Issues and PRs related to the stream subsystem. label Aug 23, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020

nodejs-github-bot commented Aug 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32896/

ronag requested changes Aug 23, 2020
View reviewed changes
Comment thread lib/_stream_readable.js
ronag requested changes Aug 23, 2020
View reviewed changes

ronag left a comment •
edited
Loading

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The properties are already defined below? Also would need tests.

EDIT: Something is weird here. I think you should remove the properties from Readable and like you do add them to ReadableState instead. Looks like a mistake in #31144.

lpinca commented Aug 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

The properties are already defined below? Also would need tests.

One definition is on Readable, the other is on ReadableState. It looks like no reviewer noticed this in #31144 :/

ronag commented Aug 23, 2020 •
edited
Loading

Copy link
Copy Markdown
Member

One definition is on Readable

I think it was moved to Readable by mistake and should have been on ReadableState. Any chance we could remove it from Readable?

lpinca commented Aug 23, 2020

Copy link
Copy Markdown
Member

I'm 👍 on keeping these only on ReadableState as it originally was before #31144.

lpinca commented Aug 23, 2020

Copy link
Copy Markdown
Member

The change on #31144 was unintentional and broken anyway.

lundibundi mentioned this pull request Aug 23, 2020
Closed
4 tasks

lundibundi commented Aug 23, 2020

Copy link
Copy Markdown
Member Author

I'm good with keeping them on state only but since they were present (though broken) on Readable I thought it'd be better to leave them on Readable as well.

Though I've used .paused to remove the readable state usage in http #34888, can we replace it with something else?

ronag commented Aug 23, 2020

Copy link
Copy Markdown
Member

Though I've used .paused to remove the readable state usage in http #34888, can we replace it with something else?

isPaused()?

lundibundi commented Aug 23, 2020

Copy link
Copy Markdown
Member Author

@ronag oh, that makes sense 😄

stream: fix Readable stream state properties
9cc6c1f 
Looks like they have been accidentally moved in
nodejs#31144.
lundibundi force-pushed the fix-stream-getter-props branch from caeb4e8 to 9cc6c1f Compare August 23, 2020 10:30
lundibundi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020

nodejs-github-bot commented Aug 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32899/

ronag commented Aug 23, 2020

Copy link
Copy Markdown
Member

What's request-ci label? Is there some bot that looks at that and starts ci automatically?

github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020

nodejs-github-bot commented Aug 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32900/

lundibundi commented Aug 23, 2020

Copy link
Copy Markdown
Member Author

@ronag yep, #34594

lpinca reviewed Aug 23, 2020
View reviewed changes
Comment thread lib/_stream_readable.js Outdated
lundibundi added the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020
github-actions Bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Aug 23, 2020

nodejs-github-bot commented Aug 23, 2020

Copy link
Copy Markdown
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/32901/

mcollina approved these changes Aug 23, 2020
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lgtm

antsmartian approved these changes Aug 24, 2020
View reviewed changes

antsmartian left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Looks like I missed it somehow :/

mcollina added the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Aug 24, 2020

github-actions Bot commented Aug 24, 2020

Copy link
Copy Markdown
Contributor
Commit Queue failed
- Loading data for nodejs/node/pull/34886
✔  Done loading data for nodejs/node/pull/34886
----------------------------------- PR info ------------------------------------
Title      stream: fix Readable stream state properties (#34886)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     lundibundi:fix-stream-getter-props -> nodejs:master
Labels     stream
Commits    2
 - stream: fix Readable stream state properties
 - fixup! stream: fix Readable stream state properties
Committers 1
 - Denys Otrishko 
PR-URL: https://github.com/nodejs/node/pull/34886
Reviewed-By: Robert Nagy 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina 
Reviewed-By: Zeyu Yang 
Reviewed-By: Anto Aravinth 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/34886
Reviewed-By: Robert Nagy 
Reviewed-By: Luigi Pinca 
Reviewed-By: Matteo Collina 
Reviewed-By: Zeyu Yang 
Reviewed-By: Anto Aravinth 
--------------------------------------------------------------------------------
   ℹ  Last Full PR CI on 2020-08-23T10:56:51Z: https://ci.nodejs.org/job/node-test-pull-request/32901/
- Querying data of job/node-test-pull-request/32901/
✔  Build data downloaded
   ℹ  This PR was created on Sun, 23 Aug 2020 09:24:58 GMT
   ✔  Approvals: 5
   ✔  - Robert Nagy (@ronag): https://github.com/nodejs/node/pull/34886#pullrequestreview-472999909
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/34886#pullrequestreview-472996953
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/34886#pullrequestreview-473001353
   ✔  - Zeyu Yang (@himself65): https://github.com/nodejs/node/pull/34886#pullrequestreview-473012786
   ✔  - Anto Aravinth (@antsmartian): https://github.com/nodejs/node/pull/34886#pullrequestreview-473059639
   ✖  This PR needs to wait 27 more hours to land
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

github-actions Bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 24, 2020
lundibundi removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Aug 25, 2020
lundibundi added the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 1, 2020
github-actions Bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Sep 1, 2020

github-actions Bot commented Sep 1, 2020

Copy link
Copy Markdown
Contributor

Landed in e2ffa45

github-actions Bot closed this Sep 1, 2020
nodejs-github-bot pushed a commit that referenced this pull request Sep 1, 2020
stream: fix Readable stream state properties
e2ffa45 
Looks like they have been accidentally moved in
#31144.

PR-URL: #34886
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
lundibundi deleted the fix-stream-getter-props branch September 1, 2020 20:43
richardlau pushed a commit that referenced this pull request Sep 2, 2020
stream: fix Readable stream state properties
098711e 
Looks like they have been accidentally moved in
#31144.

PR-URL: #34886
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
richardlau mentioned this pull request Sep 2, 2020
Merged
4 tasks
richardlau pushed a commit that referenced this pull request Sep 3, 2020
stream: fix Readable stream state properties
5f24cea 
Looks like they have been accidentally moved in
#31144.

PR-URL: #34886
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
stream: fix Readable stream state properties
eeebc31 
Looks like they have been accidentally moved in
nodejs#31144.

PR-URL: nodejs#34886
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

lpinca lpinca approved these changes
mcollina mcollina approved these changes
ronag ronag approved these changes
himself65 himself65 approved these changes
+2 more reviewers
antsmartian antsmartian approved these changes
rickyes rickyes approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

stream Issues and PRs related to the stream subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL