FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: refactor test and add common.mustCall by bchirgwin · Pull Request #10017 · nodejs/node · GitHub

/ node Public

test: refactor test and add common.mustCall - #10017

Closed
bchirgwin wants to merge 1 commit into
nodejs:masterfrom
bchirgwin:btc-test-parallel-interleave
ConversationCommits (1)ChecksFiles changed
Closed

test: refactor test and add common.mustCall#10017
bchirgwin wants to merge 1 commit into
nodejs:masterfrom
bchirgwin:btc-test-parallel-interleave

Conversation

bchirgwin commented Dec 1, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

var -> let / const
added common.mustCall to callbacks

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016
mscdex added the tls Issues and PRs related to the tls subsystem. label Dec 1, 2016
imyller added code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. tls Issues and PRs related to the tls subsystem. and removed tls Issues and PRs related to the tls subsystem. labels Dec 1, 2016
cjihrig requested changes Dec 5, 2016
View reviewed changes
Comment thread test/parallel/test-tls-interleave.js Outdated

cjihrig Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

This line can be moved below the common.hasCrypto check.

Comment thread test/parallel/test-tls-interleave.js Outdated

cjihrig Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I think these lines should be indented now.

Comment thread test/parallel/test-tls-interleave.js Outdated

cjihrig Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

The common.mustCall() here seems unnecessary.

Comment thread test/parallel/test-tls-interleave.js Outdated

cjihrig Dec 5, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Please remove the unnecessary added blank lines.

Trott commented Dec 22, 2016

Copy link
Copy Markdown
Member

Ping @bchirgwin: Are you able to update this based on the comments from @cjihrig?

test: refactor test and add common.mustCall
f6f5f3e 
var -> let / const
added common.mustCall() to callback
assert.equal() -> assert.strictEqual()

Trott commented Dec 24, 2016

Copy link
Copy Markdown
Member

@cjihrig I updated this per your comments and pushed to @bchirgwin's branch. Can you please take a look and, if appropriate, update your review? Thanks!

Trott commented Dec 24, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5571/

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 24, 2016
test: refactor test-tls-interleave
6281a1c 
var -> let / const
added common.mustCall() to callback
assert.equal() -> assert.strictEqual()

PR-URL: nodejs#10017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Trott commented Dec 24, 2016

Copy link
Copy Markdown
Member

Landed in 6281a1c.
Thanks for the contribution! 🎉

Trott closed this Dec 24, 2016
targos pushed a commit that referenced this pull request Dec 26, 2016
test: refactor test-tls-interleave
21a6091 
var -> let / const
added common.mustCall() to callback
assert.equal() -> assert.strictEqual()

PR-URL: #10017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Dec 27, 2016
Merged
targos pushed a commit that referenced this pull request Dec 28, 2016
test: refactor test-tls-interleave
361c019 
var -> let / const
added common.mustCall() to callback
assert.equal() -> assert.strictEqual()

PR-URL: #10017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
test: refactor test-tls-interleave
87be4e3 
var -> let / const
added common.mustCall() to callback
assert.equal() -> assert.strictEqual()

PR-URL: #10017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
test: refactor test-tls-interleave
1b9f548 
var -> let / const
added common.mustCall() to callback
assert.equal() -> assert.strictEqual()

PR-URL: #10017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
test: refactor test-tls-interleave
9b13d98 
var -> let / const
added common.mustCall() to callback
assert.equal() -> assert.strictEqual()

PR-URL: #10017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
test: refactor test-tls-interleave
76f3c7e 
var -> let / const
added common.mustCall() to callback
assert.equal() -> assert.strictEqual()

PR-URL: #10017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
test: refactor test-tls-interleave
a983400 
var -> let / const
added common.mustCall() to callback
assert.equal() -> assert.strictEqual()

PR-URL: #10017
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. test Issues and PRs related to the tests. tls Issues and PRs related to the tls subsystem.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL