test: update test-fs-write-file - #10030
Closed
radelmann wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
@radelmann May I kindly ask you to format the commit message as described in CONTRIBUTING guidelines. |
Sorry, something went wrong.
radelmann
force-pushed
the
FIRST-PR
branch
2 times, most recently
from
0e81222 to
20941b1
Compare
December 1, 2016 18:12
cjihrig
reviewed
Dec 3, 2016
Comment thread
test/parallel/test-fs-write-file.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
While you're here, would you mind replacing all the if (e) throw e; checks with assert.ifError(e);?
Sorry, something went wrong.
Changed all instances of var to either const or let. Changed all instances of assert.equal() to assert.strictEqual(). Replaced all error checks with assert.ifError(e).
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Trott
approved these changes
Dec 4, 2016
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM if CI is ✅
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
Landed in f23dc6e4e597acb4ddae97b307a30c5b277054c0. Thanks for the contribution! 🎉 |
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 4, 2016
Replaced all error checks with assert.ifError(e). PR-URL: nodejs#10030 Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Replaced all error checks with assert.ifError(e). PR-URL: #10030 Reviewed-By: Rich Trott <rtrott@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Replaced all error checks with assert.ifError(e). PR-URL: nodejs#10030 Reviewed-By: Rich Trott <rtrott@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Replaced all error checks with assert.ifError(e). PR-URL: nodejs#10030 Reviewed-By: Rich Trott <rtrott@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Replaced all error checks with assert.ifError(e). PR-URL: #10030 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change