test: refactor test-pipe-file-to-http - #10054
Conversation
Sorry, something went wrong.
There was a problem hiding this comment.
Because this is now in a common.mustCall(), you should be able to remove clientReqComplete from the test completely.
Sorry, something went wrong.
There was a problem hiding this comment.
You can replace this with assert.ifError(err);
Sorry, something went wrong.
|
Ping @JoshuaMays: Are you able to update this to accommodate the comments from @cjihrig? Do you need a little more explanation on one or both of the comments? |
Sorry, something went wrong.
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall
|
Because this had been dormant for some time, I went ahead and addressed @cjihrig's nits and pushed directly to your branch, @JoshuaMays. Hope that's OK! @cjihrig Can you take a look and, if appropriate, update your review? Thanks! |
Sorry, something went wrong.
Sorry, something went wrong.
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: nodejs#10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
|
Landed in 00da58d. |
Sorry, something went wrong.
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Changing var defs to const/let, changing assert.equal to assert.strictEqual. Wrapping functions called once with common.mustCall PR-URL: #10054 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Checklist
Affected core subsystem(s)
Description of change
Changing var defs to const/let, changing assert.equal to
assert.strictEqual. Wrapping functions called once with
common.mustCall