test: refactor test-crypto-hash-stream-pipe - #10055
Closed
matt-wilson-cc wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Change var to const, assert.equal to assert.strictEqual
cjihrig
approved these changes
Dec 3, 2016
Copy link
Copy Markdown
Member
Sorry, something went wrong.
santigimeno
reviewed
Dec 4, 2016
Comment thread
test/parallel/test-crypto-hash-stream-pipe.js
| var common = require('../common'); | ||
| var assert = require('assert'); | ||
| const common = require('../common'); | ||
| const assert = require('assert'); |
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Maybe moving const assert = require('assert'); after the if (!common.hasCrypto) {
Sorry, something went wrong.
santigimeno
approved these changes
Dec 4, 2016
santigimeno
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with one suggestion
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
BTW, this looks like a duplicate of #9935 |
Sorry, something went wrong.
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 4, 2016
Change var to const. PR-URL: nodejs#10055 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Copy link
Copy Markdown
Member
|
Landed in c0c67c9. (Took care of @santigimeno's nit while landing.) Thanks for the contribution! 🎉 |
Sorry, something went wrong.
addaleax
pushed a commit
that referenced
this pull request
Dec 5, 2016
Change var to const. PR-URL: #10055 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
Change var to const. PR-URL: nodejs#10055 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
Change var to const. PR-URL: nodejs#10055 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
Change var to const. PR-URL: #10055 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
9 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
Change var to const, assert.equal to assert.strictEqual