test: refactor test-repl-mode.js - #10061
Closed
cesarhq wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
* var -> const/let
* assert.equal() -> assert.strictEqual()
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
evanlucas
approved these changes
Dec 1, 2016
evanlucas
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
LGTM. Thanks!
Sorry, something went wrong.
cjihrig
approved these changes
Dec 1, 2016
Fishrock123
approved these changes
Dec 2, 2016
Trott
pushed a commit
to Trott/io.js
that referenced
this pull request
Dec 5, 2016
* var -> const/let * assert.equal() -> assert.strictEqual() PR-URL: nodejs#10061 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Copy link
Copy Markdown
Member
|
Landed in 4f3c761. |
Sorry, something went wrong.
Fishrock123
pushed a commit
that referenced
this pull request
Dec 5, 2016
* var -> const/let * assert.equal() -> assert.strictEqual() PR-URL: #10061 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
addaleax
pushed a commit
to addaleax/node
that referenced
this pull request
Dec 8, 2016
* var -> const/let * assert.equal() -> assert.strictEqual() PR-URL: nodejs#10061 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
jmdarling
pushed a commit
to jmdarling/node
that referenced
this pull request
Dec 8, 2016
* var -> const/let * assert.equal() -> assert.strictEqual() PR-URL: nodejs#10061 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 21, 2016
* var -> const/let * assert.equal() -> assert.strictEqual() PR-URL: #10061 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
Dec 28, 2016
* var -> const/let * assert.equal() -> assert.strictEqual() PR-URL: #10061 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 23, 2017
* var -> const/let * assert.equal() -> assert.strictEqual() PR-URL: #10061 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* var -> const/let * assert.equal() -> assert.strictEqual() PR-URL: #10061 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 1, 2017
* var -> const/let * assert.equal() -> assert.strictEqual() PR-URL: #10061 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
10 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
Description of change
* var -> const/let * assert.equal() -> assert.strictEqual()