FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: test-http-unix-socket.js - var -> const, assert.equal -> assert.strictEqual by davidmarkclements · Pull Request #10072 · nodejs/node · GitHub

/ node Public

test: test-http-unix-socket.js - var -> const, assert.equal -> assert.strictEqual - #10072

Closed
davidmarkclements wants to merge 1 commit into
nodejs:masterfrom
davidmarkclements:test-http-unix-socket-patch
ConversationCommits (1)ChecksFiles changed
Closed

test: test-http-unix-socket.js - var -> const, assert.equal -> assert.strictEqual#10072
davidmarkclements wants to merge 1 commit into
nodejs:masterfrom
davidmarkclements:test-http-unix-socket-patch

Conversation

davidmarkclements commented Dec 1, 2016 •
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test, crypto

Description of change

changes assert.equal to assert.strictEqual to ensure specificity

changes var declarations to const to take advantage of es6 immutable bindings

edit: correct subsystem

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 1, 2016

santigimeno commented Dec 1, 2016

Copy link
Copy Markdown
Member

LGTM other than the commit message should follow these rules

davidmarkclements commented Dec 1, 2016

Copy link
Copy Markdown
Member Author

@santigimeno specifically the column count or is there also something else?

santigimeno commented Dec 1, 2016

Copy link
Copy Markdown
Member

@davidmarkclements also the format: subsystem: commit message. In this case it could be: test: refactor test-http-unix-socket

davidmarkclements changed the title test-http-unix-socket.js: var -> const, assert.equal -> assert.strictEqual test: test-http-unix-socket.js - var -> const, assert.equal -> assert.strictEqual Dec 1, 2016
mcollina reviewed Dec 1, 2016
View reviewed changes
Comment thread test/parallel/test-http-unix-socket.js Outdated

mcollina Dec 1, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

while we are editing this, can you please use common.mustCall in those two functions?

addaleax added the code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. label Dec 2, 2016
cjihrig requested changes Dec 3, 2016
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

It might be good to replace the req.on('error', ...) handler if common.fail() instead of explicitly calling process.exit().

mscdex added the http Issues or PRs related to the http subsystem. label Dec 3, 2016
test: refactor test-http-unix-socket
13c4616 
Use `common.mustCall()` and `common.fail()` where appropriate.

Change `assert.equal` to `assert.strictEqual` to ensure specificity.

Change var declarations to const to take advantage of ES6 immutable
bindings.

Trott commented Dec 7, 2016

Copy link
Copy Markdown
Member

@cjihrig @mcollina I've made changes per your comments and force pushed them to @davidmarkclements's branch. PTAL.

Trott commented Dec 7, 2016

Copy link
Copy Markdown
Member

CI: https://ci.nodejs.org/job/node-test-pull-request/5299/

mcollina approved these changes Dec 7, 2016
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Trott pushed a commit to Trott/io.js that referenced this pull request Dec 8, 2016
test: refactor test-http-unix-socket
444b907 
Use `common.mustCall()` and `common.fail()` where appropriate.

Change `assert.equal` to `assert.strictEqual` to ensure specificity.

Change var declarations to const to take advantage of ES6 immutable
bindings.

PR-URL: nodejs#10072
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

Trott commented Dec 8, 2016

Copy link
Copy Markdown
Member

Landed in 444b907.
Thanks for the contribution! 🎉

Trott closed this Dec 8, 2016
Fishrock123 pushed a commit that referenced this pull request Dec 13, 2016
test: refactor test-http-unix-socket
1ebb5b9 
Use `common.mustCall()` and `common.fail()` where appropriate.

Change `assert.equal` to `assert.strictEqual` to ensure specificity.

Change var declarations to const to take advantage of ES6 immutable
bindings.

PR-URL: #10072
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas mentioned this pull request Dec 15, 2016
Merged
MylesBorins pushed a commit that referenced this pull request Jan 16, 2017
test: refactor test-http-unix-socket
14f06f5 
Use `common.mustCall()` and `common.fail()` where appropriate.

Change `assert.equal` to `assert.strictEqual` to ensure specificity.

Change var declarations to const to take advantage of ES6 immutable
bindings.

PR-URL: #10072
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins added dont-land-on-v4.x and removed code-and-learn Issues related to the Code-and-Learn events and PRs submitted during the events. labels Jan 16, 2017
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
test: refactor test-http-unix-socket
342a3c9 
Use `common.mustCall()` and `common.fail()` where appropriate.

Change `assert.equal` to `assert.strictEqual` to ensure specificity.

Change var declarations to const to take advantage of ES6 immutable
bindings.

PR-URL: #10072
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
test: refactor test-http-unix-socket
8e7f150 
Use `common.mustCall()` and `common.fail()` where appropriate.

Change `assert.equal` to `assert.strictEqual` to ensure specificity.

Change var declarations to const to take advantage of ES6 immutable
bindings.

PR-URL: #10072
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

http Issues or PRs related to the http subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

9 participants

Back | FazBrowse Home | New Git URL