FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

fs: re-enable watch facility in AIX by gireeshpunathil · Pull Request #10085 · nodejs/node · GitHub

/ node Public

fs: re-enable watch facility in AIX - #10085

Closed
gireeshpunathil wants to merge 1 commit into
nodejs:masterfrom
gireeshpunathil:fs
ConversationCommits (1)ChecksFiles changed
Closed

fs: re-enable watch facility in AIX#10085
gireeshpunathil wants to merge 1 commit into
nodejs:masterfrom
gireeshpunathil:fs

Conversation

gireeshpunathil commented Dec 2, 2016 •
edited by Fishrock123
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

fs

Description of change

Please refer to 5085 for a full description of the background, need for this PR, and the changes.

On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

nodejs-github-bot added the libuv Issues and PRs related to the libuv dependency or the uv binding. label Dec 2, 2016

Trott commented Dec 2, 2016 •
edited
Loading

Copy link
Copy Markdown
Member

I am excited to see the AIX exceptions removed from parallel.status. Thanks for doing this!

The JS test code change looks good to me. The text in the paragraph added to the doc needs some editing. Maybe someone from @nodejs/documentation can take a look and provide a reformatted version.

Trott commented Dec 2, 2016

Copy link
Copy Markdown
Member

Oh, I see there are changes in deps/uv. I suspect those would need to be upstreamed to the libuv project. (Do we float patches on libuv?)

bnoordhuis commented Dec 2, 2016

Copy link
Copy Markdown
Member

Do we float patches on libuv?

No.

gireeshpunathil commented Dec 2, 2016

Copy link
Copy Markdown
Member Author

@Trott , @bnoordhuis , thanks. So what is the recommendation here? first have a PR for the uv change, and then come back here with the rest of the changes? or progress this PMR and schedule the uv PR before the next libuv release separately? sorry for being blunt here, I don't know the process much.

bnoordhuis commented Dec 2, 2016

Copy link
Copy Markdown
Member

@gireeshpunathil libuv PR -> libuv release -> libuv upgrade in node -> node PR -> node release. You can file the node PR ahead of time but it can't land until the libuv upgrade.

gireeshpunathil commented Dec 2, 2016

Copy link
Copy Markdown
Member Author

ok, got it. will work on the libuv PR, to follow the sequence.

gireeshpunathil mentioned this pull request Dec 3, 2016
Closed
mscdex added the aix Issues and PRs related to the AIX platform. label Dec 3, 2016
gireeshpunathil mentioned this pull request Feb 7, 2017
Closed
2 tasks
mhdawson approved these changes Feb 7, 2017
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

thefourtheye reviewed Feb 8, 2017
View reviewed changes
Comment thread doc/api/fs.md Outdated

thefourtheye Feb 8, 2017

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

lose

jasnell Feb 8, 2017

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Suggest rewording just a bit...

Moreover, save and close operations on some platforms cause inode changes
that force watch operations to become invalid and ineffective.

jasnell approved these changes Feb 8, 2017
View reviewed changes

jasnell left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

One nit but otherwise LGTM

fs: re-enable watch facility in AIX
be43a1e 
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

gireeshpunathil commented Feb 9, 2017

Copy link
Copy Markdown
Member Author

made the doc changes as per @jasnell . @thefourtheye - thanks, your change proposal is indirectly addressed, as the entire sentence is now modified.

thefourtheye approved these changes Feb 9, 2017
View reviewed changes

thefourtheye left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

@gireeshpunathil Thanks :-)

cjihrig approved these changes Feb 9, 2017
View reviewed changes

cjihrig left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM. CI before landing: https://ci.nodejs.org/job/node-test-pull-request/6318/

cjihrig commented Feb 9, 2017

Copy link
Copy Markdown
Contributor

Landed in 46edd94. Thanks!

cjihrig closed this Feb 9, 2017
cjihrig pushed a commit that referenced this pull request Feb 9, 2017
fs: re-enable watch facility in AIX
46edd94 
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: #11094
Refs: #5085
PR-URL: #10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

gireeshpunathil commented Feb 10, 2017

Copy link
Copy Markdown
Member Author

thanks everyone!

italoacasas pushed a commit that referenced this pull request Feb 13, 2017
fs: re-enable watch facility in AIX
353a4dc 
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: #11094
Refs: #5085
PR-URL: #10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
italoacasas mentioned this pull request Feb 13, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Feb 14, 2017
fs: re-enable watch facility in AIX
9339891 
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: nodejs#11094
Refs: nodejs#5085
PR-URL: nodejs#10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
krydos pushed a commit to krydos/node that referenced this pull request Feb 25, 2017
fs: re-enable watch facility in AIX
f6a5725 
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: nodejs#11094
Refs: nodejs#5085
PR-URL: nodejs#10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>

jasnell commented Mar 7, 2017

Copy link
Copy Markdown
Member

should this land in v6 or v4?

gireeshpunathil commented Mar 8, 2017

Copy link
Copy Markdown
Member Author

I guess no, as this PR depends on aix: re-enable fs watch facility from libuv 1.11.0, which v6 and v4 haven't consumed.

gireeshpunathil commented Mar 8, 2017

Copy link
Copy Markdown
Member Author

@jasnell - ok, I see your question to LTS in 11094 as well. So answer here will depend on that decision.

MylesBorins mentioned this pull request May 16, 2017
Closed
MylesBorins pushed a commit that referenced this pull request May 16, 2017
fs: re-enable watch facility in AIX
4b8c6dd 
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: #11094
Refs: #5085
PR-URL: #10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
fs: re-enable watch facility in AIX
afec45c 
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: #11094
Refs: #5085
PR-URL: #10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins pushed a commit that referenced this pull request May 18, 2017
fs: re-enable watch facility in AIX
ae1f6fd 
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: #11094
Refs: #5085
PR-URL: #10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
MylesBorins mentioned this pull request May 23, 2017
Merged
andrew749 pushed a commit to michielbaird/node that referenced this pull request Jul 19, 2017
fs: re-enable watch facility in AIX
5c82c36 
On AIX, watch feature depends on AHAFS based Event infrastructure.
While in principle the watch use case is same across platforms, there
are subtle differences in the way AIX deals with this, with few
behavioral changes (external).

This commit addresses an assertion failure on folder watch, enabling the
AIX code for watch feature which was masked under a macro, open up
relevant test cases, skip tests which comes under the AIX limitation,
and make the document changes as appropriate.

Refs: nodejs/node#11094
Refs: nodejs/node#5085
PR-URL: nodejs/node#10085
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
santigimeno santigimeno approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
thefourtheye thefourtheye approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

aix Issues and PRs related to the AIX platform. libuv Issues and PRs related to the libuv dependency or the uv binding.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Back | FazBrowse Home | New Git URL