FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

doc: buffer allocation methods throw for negative size by joyeecheung · Pull Request #10151 · nodejs/node · GitHub

/ node Public

doc: buffer allocation methods throw for negative size - #10151

Closed
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:fix-buffer-negative
ConversationCommits (1)ChecksFiles changed
Closed

doc: buffer allocation methods throw for negative size#10151
joyeecheung wants to merge 1 commit into
nodejs:masterfrom
joyeecheung:fix-buffer-negative

Conversation

joyeecheung commented Dec 6, 2016

Copy link
Copy Markdown
Member
Checklist
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)

doc

Description of change

Update the doc to match the current behavior.

Ref: #7079

nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations. labels Dec 6, 2016
sam-github suggested changes Dec 6, 2016
View reviewed changes
Comment thread doc/api/buffer.md Outdated

sam-github Dec 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

if size is 0

Use English words consistently, as in the previous sentence.

joyeecheung Dec 6, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Thanks for pointing this out. Addressed.

sam-github added the semver-major PRs that contain breaking changes and should be released in the next major version. label Dec 6, 2016
sam-github suggested changes Dec 6, 2016
View reviewed changes
Comment thread doc/api/buffer.md Outdated

sam-github Dec 6, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

is 0

joyeecheung Dec 6, 2016

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Fixed. Sorry for pushing too fast before the review complete.

sam-github commented Dec 6, 2016

Copy link
Copy Markdown
Contributor

Why did you say issue is addressed? Did you forget to push? There are still 5 instances of === used in the doc text.

addaleax added dont-land-on-v4.x and removed semver-major PRs that contain breaking changes and should be released in the next major version. labels Dec 6, 2016

addaleax commented Dec 6, 2016

Copy link
Copy Markdown
Member

@sam-github Why did you tag this semver-major? This matches current behaviour on v7.x.

joyeecheung commented Dec 6, 2016

Copy link
Copy Markdown
Member Author

Why did you say issue is addressed? Did you forget to push? There are still 5 instances of === used in the doc text.

Sorry, I pushed before the review was finished, so it's partially addressed.

vsemozhetbyt mentioned this pull request Dec 6, 2016
Closed
2 tasks

sam-github commented Dec 6, 2016

Copy link
Copy Markdown
Contributor

@addaleax sorry, I thought this was changing the Buffer to throw

joyeecheung commented Dec 9, 2016

Copy link
Copy Markdown
Member Author

Ping. Is there anything stopping this from being landed?

cjihrig commented Dec 9, 2016

Copy link
Copy Markdown
Contributor

It needs a CI run. So, https://ci.nodejs.org/job/node-test-pull-request/5341/

addaleax commented Dec 9, 2016

Copy link
Copy Markdown
Member

@cjihrig It’s a docs change :)

I think the only thing this has been waiting for were the mandatory 48 hours before landing but we might as well wait for CI to finish now that it’s started

cjihrig commented Dec 9, 2016

Copy link
Copy Markdown
Contributor

@addaleax D'oh. I looked that it had been reviewed and saw there was no CI run, but didn't look at anything else. 😔

addaleax pushed a commit that referenced this pull request Dec 9, 2016
doc: buffer allocation throws for negative size
bc335c0 
PR-URL: #10151
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

addaleax commented Dec 9, 2016

Copy link
Copy Markdown
Member

Landed in bc335c0 (had to trim the commit subject line a bit to fit it into 50 characters)

Thanks for the ping!

addaleax closed this Dec 9, 2016

joyeecheung commented Dec 9, 2016

Copy link
Copy Markdown
Member Author

I think the only thing this has been waiting for were the mandatory 48 hours before landing but we might as well wait for CI to finish now that it’s started

Hmm.. I had no idea that there is a mandatory 48 hours wait. Did a little bit of searching and turns out it is described in the onboarding guide, but I think the contributing guide should mention this as well?

joyeecheung mentioned this pull request Dec 9, 2016
Closed
2 tasks
Fishrock123 pushed a commit that referenced this pull request Dec 13, 2016
doc: buffer allocation throws for negative size
5a64187 
PR-URL: #10151
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas mentioned this pull request Dec 15, 2016
Merged
gibfahn pushed a commit that referenced this pull request Dec 22, 2016
doc: clarify the review and landing process
44b38bb 
Adds/mentions:
- Link to glossary
- Commit squashing and CI run
- 48/72 hour wait and PR review feature
- Extra notes section
- "Landed in <sha>" comment

PR-URL: #10202
Ref: #10151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
joyeecheung deleted the fix-buffer-negative branch January 2, 2017 05:28
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
doc: clarify the review and landing process
ca7174a 
Adds/mentions:
- Link to glossary
- Commit squashing and CI run
- 48/72 hour wait and PR review feature
- Extra notes section
- "Landed in <sha>" comment

PR-URL: #10202
Ref: #10151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
doc: clarify the review and landing process
b67879f 
Adds/mentions:
- Link to glossary
- Commit squashing and CI run
- 48/72 hour wait and PR review feature
- Extra notes section
- "Landed in <sha>" comment

PR-URL: #10202
Ref: #10151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
doc: clarify the review and landing process
d9b955b 
Adds/mentions:
- Link to glossary
- Commit squashing and CI run
- 48/72 hour wait and PR review feature
- Extra notes section
- "Landed in <sha>" comment

PR-URL: #10202
Ref: #10151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
doc: clarify the review and landing process
01a2299 
Adds/mentions:
- Link to glossary
- Commit squashing and CI run
- 48/72 hour wait and PR review feature
- Extra notes section
- "Landed in <sha>" comment

PR-URL: #10202
Ref: #10151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
doc: clarify the review and landing process
6dfddc8 
Adds/mentions:
- Link to glossary
- Commit squashing and CI run
- 48/72 hour wait and PR review feature
- Extra notes section
- "Landed in <sha>" comment

PR-URL: #10202
Ref: #10151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
doc: clarify the review and landing process
06b185a 
Adds/mentions:
- Link to glossary
- Commit squashing and CI run
- 48/72 hour wait and PR review feature
- Extra notes section
- "Landed in <sha>" comment

PR-URL: #10202
Ref: #10151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
doc: clarify the review and landing process
8e7749e 
Adds/mentions:
- Link to glossary
- Commit squashing and CI run
- 48/72 hour wait and PR review feature
- Extra notes section
- "Landed in <sha>" comment

PR-URL: #10202
Ref: #10151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
doc: clarify the review and landing process
f7c0eb8 
Adds/mentions:
- Link to glossary
- Commit squashing and CI run
- 48/72 hour wait and PR review feature
- Extra notes section
- "Landed in <sha>" comment

PR-URL: #10202
Ref: #10151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
doc: clarify the review and landing process
5777c79 
Adds/mentions:
- Link to glossary
- Commit squashing and CI run
- 48/72 hour wait and PR review feature
- Extra notes section
- "Landed in <sha>" comment

PR-URL: #10202
Ref: #10151
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Evan Lucas <evanlucas@me.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes
+2 more reviewers
sam-github sam-github approved these changes
Fishrock123 Fishrock123 approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

buffer Issues and PRs related to the buffer subsystem. doc Issues and PRs related to the documentations.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL