test: refactor the code in test-dns-ipv4 - #10200
Conversation
Sorry, something went wrong.
|
Can't we also get rid of the expected and completed variables now that we're using common.mustCall()? |
Sorry, something went wrong.
There was a problem hiding this comment.
Would you mind replacing all of these lines in the file with assert.ifError(err);
Sorry, something went wrong.
There was a problem hiding this comment.
will perform these changes later tonight
Sorry, something went wrong.
Sorry, something went wrong.
There was a problem hiding this comment.
I'd rather either see this indented or use an arrow function to keep it on the previous line. If you go the arrow function route, we should be more consistent though and use it for the other callbacks too.
Same goes for the other instances below.
Sorry, something went wrong.
There was a problem hiding this comment.
common should be required before anything else.
Sorry, something went wrong.
There was a problem hiding this comment.
will do this change too after get the #10219 approved, I am learning the right format for the code
Sorry, something went wrong.
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal
|
changed the style to match the one agreed in #10219 |
Sorry, something went wrong.
Sorry, something went wrong.
|
any update on this one? |
Sorry, something went wrong.
Sorry, something went wrong.
|
landing this tomorrow if not objections @nodejs/collaboration |
Sorry, something went wrong.
|
@italoacasas I think you meant @nodejs/collaborators |
Sorry, something went wrong.
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: #10200 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: #10200 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: #10200 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: #10200 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: #10200 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
* remove the manual control for functions execution * use common.mustCall to control the functions execution automatically * use let and const instead of var * use assert.strictEqual instead assert.equal PR-URL: #10200 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Checklist
Affected core subsystem(s)
test
Description of change
use let and const instead of var
add missing common.mustCall for anonymous functions