FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

deps: ICU 58.2 bump by srl295 · Pull Request #10206 · nodejs/node · GitHub

/ node Public

deps: ICU 58.2 bump - #10206

Closed
srl295 wants to merge 2 commits into
nodejs:masterfrom
srl295:icu4c-58.2
ConversationCommits (2)ChecksFiles changed
Closed

deps: ICU 58.2 bump#10206
srl295 wants to merge 2 commits into
nodejs:masterfrom
srl295:icu4c-58.2

Conversation

srl295 commented Dec 9, 2016 •
edited
Loading

Copy link
Copy Markdown
Member
Checklist
  • make -j8 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

deps

Description of change

No feature changes. Bug fixes.

Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

  • CLDR 30.0.3 ( was 30.0.2)
  • Timezone 2016j ( was 2016g )

srl295 added wip Issues and PRs that are still a work in progress. i18n-api Issues and PRs related to the i18n implementation. labels Dec 9, 2016
srl295 self-assigned this Dec 9, 2016
srl295 commented Dec 9, 2016
View reviewed changes

srl295 left a comment •
edited
Loading

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Note: actual impact is smaller than what's here due to whitespace when it actually lands. I'll see if I can figure out how to reduce the whitespace churn here.

Guess i need to 'land' the PR on a branch with am … fix-whitespace .. and force push that branch back

srl295 commented Dec 9, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

58.2 was released http://site.icu-project.org/download/58

srl295 removed the wip Issues and PRs that are still a work in progress. label Dec 10, 2016
Fishrock123 reopened this Dec 12, 2016

Fishrock123 commented Dec 12, 2016

Copy link
Copy Markdown
Contributor

Sorry about that.

@srl295 should this be backported to LTS?

mhdawson commented Dec 12, 2016

Copy link
Copy Markdown
Member

Removing the whitespace changes would make it a lot easier to review.

deps: ICU 58.2 bump
cf8ab08 
No feature changes. Bug fixes.

Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )
deps: Bump ICU download path to 58.2
5366488 
* update configure to new path

PR-URL: nodejs#10206

srl295 commented Dec 14, 2016 •
edited
Loading

Copy link
Copy Markdown
Member Author

@Fishrock123 yes, i think it should be backported
@mhdawson try it now - should be a lot easier to review.

I used curl -L https://github.com/nodejs/node/pull/10206.patch | git am --whitespace=fix to "land" it on a new branch, the pushed that back. Is there an easier way to do this? If I can integrate it into the "howto upgrade ICU docs", we can make this the same way for the future.

mhdawson approved these changes Dec 14, 2016
View reviewed changes

mhdawson left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

Fishrock123 approved these changes Dec 16, 2016
View reviewed changes

Fishrock123 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

CI: https://ci.nodejs.org/job/node-test-pull-request/5443/

gibfahn commented Dec 23, 2016

Copy link
Copy Markdown
Member

@mhdawson To review without the whitespace changes you can just add ?w=1 to the end of the URL.

@srl295 I think fixing the whitespace issues is the right way to go, if people find it messy they can use the ?w=1 trick. Obviously hopefully once the issues have been fixed once then it won't continue to be a problem.

srl295 commented Dec 23, 2016 via email

Copy link
Copy Markdown
Member Author

jasnell commented Dec 27, 2016

Copy link
Copy Markdown
Member

CI : https://ci.nodejs.org/job/node-test-pull-request/5606/

srl295 commented Dec 29, 2016

Copy link
Copy Markdown
Member Author

landed in 68f004f and c830179

srl295 closed this Dec 29, 2016
srl295 deleted the icu4c-58.2 branch December 29, 2016 22:32
srl295 added a commit that referenced this pull request Dec 29, 2016
deps: ICU 58.2 bump
68f004f 
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 added a commit that referenced this pull request Dec 29, 2016
deps: ICU 58.2 bump download URL
c830179 
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
deps: ICU 58.2 bump
616fd7a 
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
deps: ICU 58.2 bump download URL
96158f9 
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
deps: ICU 58.2 bump
bce0013 
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
deps: ICU 58.2 bump download URL
785975d 
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 mentioned this pull request Jan 16, 2017
Closed
4 tasks
srl295 added a commit to srl295/node that referenced this pull request Jan 18, 2017
deps: ICU 58.2 bump
1e8afd5 
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: nodejs#10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 added a commit to srl295/node that referenced this pull request Jan 18, 2017
deps: ICU 58.2 bump download URL
9305379 
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: nodejs#10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 mentioned this pull request Jan 19, 2017
Closed
2 tasks
MylesBorins pushed a commit that referenced this pull request Jan 20, 2017
deps: ICU 58.2 bump
3462658 
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 20, 2017
deps: ICU 58.2 bump download URL
d51c637 
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
deps: ICU 58.2 bump
31dd253 
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
deps: ICU 58.2 bump download URL
72b4de5 
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins mentioned this pull request Jan 24, 2017
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
deps: ICU 58.2 bump
ae477b7 
Bump ICU from 58.1 to 58.2

No feature changes. Bug fixes.
* This commit contains the actual ICU source code and data.
* CLDR 30.0.3 ( was 30.0.2)
* Timezone 2016j ( was 2016g )

ICU Details:
http://site.icu-project.org/download/58#TOC-Updates-in-ICU-58.2

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
deps: ICU 58.2 bump download URL
687137e 
Bump configure download path for ICU from 58.1 to 58.2

* This commit just changes the download URL.

PR-URL: #10206
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
srl295 mentioned this pull request Nov 10, 2017
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
+2 more reviewers
Fishrock123 Fishrock123 approved these changes
mhdawson mhdawson approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

srl295

Labels

i18n-api Issues and PRs related to the i18n implementation.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

Back | FazBrowse Home | New Git URL