test: fix setTimeout, add const, remove unused var - #10207
Conversation
Sorry, something went wrong.
Trott
left a comment
There was a problem hiding this comment.
LGTM if CI is ✅ .
Not sure why the bot labeled it don't-land-on-v7--maybe it sees a modified test and thinks it might be a behavior change?
Sorry, something went wrong.
Sorry, something went wrong.
|
The CI check failed on node-test-binary-arm » 6,pi1-raspbian-wheezy. Is there any way to see the stack trace, which line of code failed? Or is it related to this issue #8759. |
Sorry, something went wrong.
|
The Raspberry Pi that failed had its failure during build and not test. That particular job doesn't run this test anyway. And that particular Raspberry Pi was having build failures throughout the day. (One of the admins rebooted it after I brought it to their attention, but that was after this CI run.) In short, the single CI failure is unrelated and can be ignored. |
Sorry, something went wrong.
apply setTimeout duration, add const, remove unused var PR-URL: nodejs#10207 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
|
Landed in ca58e53. |
Sorry, something went wrong.
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
apply setTimeout duration, add const, remove unused var PR-URL: #10207 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Checklist
Affected core subsystem(s)
test/parallel/test-domain.js
Description of change
Added 1ms delay for setTimeout and setInterval, instead of default 0. Changed var->const in 4 places. Removed unused function parameter.