test: refactor test-http-dns-fail - #10243
Closed
edsadr wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
LGTM |
Sorry, something went wrong.
mscdex
reviewed
Dec 12, 2016
Comment thread
test/internet/test-http-dns-fail.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I would suggest changing this to }, 2)); and then getting rid of hadError entirely.
EDIT: Actually after further review I think we can just get rid of hadError entirely without changing this line ...
Sorry, something went wrong.
mscdex
reviewed
Dec 12, 2016
Comment thread
test/internet/test-http-dns-fail.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Would you mind reversing the conditional here to count > 1 while you're in this file? I personally find it much easier to understand when scanning code...
Sorry, something went wrong.
mscdex
reviewed
Dec 12, 2016
Comment thread
test/internet/test-http-dns-fail.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
I think this should be removed? I still don't know if we have an official policy on this or not ...
Sorry, something went wrong.
* remove counter used to control function execution * use commont.mustCall to control the function execution * use const and let instead of var * use arrow functions
edsadr
force-pushed
the
test-dns-fail
branch
from
c530a79 to
db029f2
Compare
December 12, 2016 23:04
Copy link
Copy Markdown
Contributor
Author
|
@mscdex just implemented your suggestions, also removed the console.log, I was actually wondering about this... |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
italoacasas
approved these changes
Dec 13, 2016
Copy link
Copy Markdown
Contributor
|
LGTM |
Sorry, something went wrong.
cjihrig
approved these changes
Dec 13, 2016
lpinca
approved these changes
Dec 14, 2016
italoacasas
pushed a commit
that referenced
this pull request
Dec 14, 2016
* remove counter used to control function execution * use commont.mustCall to control the function execution * use const and let instead of var * use arrow functions PR-URL: #10243 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins
pushed a commit
that referenced
this pull request
Dec 15, 2016
* remove counter used to control function execution * use commont.mustCall to control the function execution * use const and let instead of var * use arrow functions PR-URL: #10243 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 22, 2017
* remove counter used to control function execution * use commont.mustCall to control the function execution * use const and let instead of var * use arrow functions PR-URL: #10243 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Brian White <mscdex@mscdex.net>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
* remove counter used to control function execution * use commont.mustCall to control the function execution * use const and let instead of var * use arrow functions PR-URL: #10243 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Brian White <mscdex@mscdex.net>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
* remove counter used to control function execution * use commont.mustCall to control the function execution * use const and let instead of var * use arrow functions PR-URL: #10243 Reviewed-By: Italo A. Casas <me@italoacasas.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Lance Ball <lball@redhat.com> Reviewed-By: Brian White <mscdex@mscdex.net>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change
refactor test-http-dns-fail.js