test: refactor test-fs-read-stream-inherit - #10246
Closed
Trott wants to merge 3 commits into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
mscdex
reviewed
Dec 13, 2016
Comment thread
test/parallel/test-fs-read-stream-inherit.js
Outdated
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
We should wrap callbacks with common.mustCall() if we are calling assert() within them.
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
There was a problem hiding this comment.
Added more common.mustCall(). PTAL
Sorry, something went wrong.
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
|
@nodejs/testing |
Sorry, something went wrong.
targos
approved these changes
Dec 14, 2016
targos
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with a suggestion
Sorry, something went wrong.
Comment thread
test/parallel/test-fs-read-stream-inherit.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I suppose this can be checked in file.on('close') like what's being done for file4.
Sorry, something went wrong.
Comment thread
test/parallel/test-fs-read-stream-inherit.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
ditto
Sorry, something went wrong.
Refactor to take advantage of block scoping to isolate tests. Checks in exit handlers now reside with the relevant test block. Where test cases start and end is more clear. Also: Some use of `common.mustCall()` and improved wrapping/indentation.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 16, 2016
Refactor to take advantage of block scoping to isolate tests. Checks in exit handlers now reside with the relevant test block. Where test cases start and end is more clear. Also: Some use of `common.mustCall()` and improved wrapping/indentation. PR-URL: nodejs#10246 Reviewed-By: Michaël Zasso <targos@protonmail.com>
italoacasas
pushed a commit
that referenced
this pull request
Dec 17, 2016
Refactor to take advantage of block scoping to isolate tests. Checks in exit handlers now reside with the relevant test block. Where test cases start and end is more clear. Also: Some use of `common.mustCall()` and improved wrapping/indentation. PR-URL: #10246 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
cjihrig
pushed a commit
that referenced
this pull request
Dec 20, 2016
Refactor to take advantage of block scoping to isolate tests. Checks in exit handlers now reside with the relevant test block. Where test cases start and end is more clear. Also: Some use of `common.mustCall()` and improved wrapping/indentation. PR-URL: #10246 Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 22, 2017
Refactor to take advantage of block scoping to isolate tests. Checks in exit handlers now reside with the relevant test block. Where test cases start and end is more clear. Also: Some use of `common.mustCall()` and improved wrapping/indentation. PR-URL: #10246 Reviewed-By: Michaël Zasso <targos@protonmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
Refactor to take advantage of block scoping to isolate tests. Checks in exit handlers now reside with the relevant test block. Where test cases start and end is more clear. Also: Some use of `common.mustCall()` and improved wrapping/indentation. PR-URL: #10246 Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
Refactor to take advantage of block scoping to isolate tests. Checks in exit handlers now reside with the relevant test block. Where test cases start and end is more clear. Also: Some use of `common.mustCall()` and improved wrapping/indentation. PR-URL: #10246 Reviewed-By: Michaël Zasso <targos@protonmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test fs
Description of change
Refactor to take advantage of block scoping to isolate tests. Checks in
exit handlers now reside with the relevant test block. Where test cases
start and end is more clear.
Also: Some use of common.mustCall() and improved wrapping/indentation.