FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

tls: update builtin cert bundle for 0.12 by sam-github · Pull Request #10261 · nodejs/node · GitHub

/ node Public

tls: update builtin cert bundle for 0.12 - #10261

Closed
sam-github wants to merge 1 commit into
nodejs:v0.12from
sam-github:update-v0.12-certdata
Closed

tls: update builtin cert bundle for 0.12#10261
sam-github wants to merge 1 commit into
nodejs:v0.12from
sam-github:update-v0.12-certdata

Conversation

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

tls

Description of change

Copied certdata.txt from master, rebuilt header using mk-ca-bundle.pl.

Fix #7962

Copied certdata.txt from master, rebuilt header using mk-ca-bundle.pl.
nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. tools Issues and PRs related to the tools directory. v0.12 labels Dec 14, 2016

Copy link
Copy Markdown
Contributor Author

/to @nodejs/lts If you want it, here it is.

/cc @bnoordhuis In case I did something wrong, but it seems pretty straighforward.

sam-github added tls Issues and PRs related to the tls subsystem. lts-watch-v0.12 labels Dec 14, 2016

mscdex commented Dec 14, 2016

Copy link
Copy Markdown
Contributor

Is it even worth merging anything v0.12-related at this point? I doubt there will be another v0.12 release before the end of the this month.

Copy link
Copy Markdown
Contributor Author

@mscdex I don't know, but @jasnell and @silverwind indicated they thought so. I'm just trying to close out tls/crypto bugs, if we can just close #7962 as "won't do", that's good, too.

Copy link
Copy Markdown
Contributor

I don't think we ended up ever doing the previously scheduled 0.12 release... So I think there will still be one, maybe next week? It was on @rvagg's plate and I can bug him about it again.

bnoordhuis commented Dec 14, 2016
edited
Loading

Copy link
Copy Markdown
Member

Sam, did you check what certificates have been added and removed? It looks like the last update was three (!) years ago, the changeset is probably quite extensive; possibly quite disruptive too for a final release.

EDIT: It's, marginally, less bad than I originally thought. The commit date is November 2013 but the certdata.txt is actually from November 2014. Ain't git wonderful?

Copy link
Copy Markdown
Contributor Author

No, I just made 0.12 support the same as master.

I think leaving 0.12 alone is probably best. This can be reopened if someone feels strongly.

sam-github closed this Dec 14, 2016
sam-github deleted the update-v0.12-certdata branch December 14, 2016 16:19
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

c++ Issues and PRs that require attention from people who are familiar with C++. tls Issues and PRs related to the tls subsystem. tools Issues and PRs related to the tools directory.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants


Back | FazBrowse Home | New Git URL