test: add known_issues test for #6287 - #10272
Closed
AnnaMag wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
3 tasks
Copy link
Copy Markdown
Contributor
|
Is this test "moved" or newly added? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
|
added- comment fixed. thanks! |
Sorry, something went wrong.
cjihrig
requested changes
Dec 16, 2016
Comment thread
test/known_issues/test-vm-deleting-property.js
Outdated
| const assert = require('assert'); | ||
| const vm = require('vm'); | ||
|
|
||
| var context = vm.createContext(); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Can this be const?
Sorry, something went wrong.
Comment thread
test/known_issues/test-vm-deleting-property.js
Outdated
| const res = vm.runInContext(` | ||
| this.x = 'prop'; | ||
| delete this.x; | ||
| Object.getOwnPropertyDescriptor(this, "x"); |
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Can you use single quotes with x here?
Sorry, something went wrong.
Comment thread
test/known_issues/test-vm-deleting-property.js
Outdated
| @@ -0,0 +1,15 @@ | |||
| 'use strict'; | |||
| // Refs:https://github.com/nodejs/node/issues/6287 | |||
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Space after the colon please.
Sorry, something went wrong.
Deleting property in the vm context has no effect as reported in nodejs#6287 The test is moved to the known_issues and will be fixed with the 5.5 V8 API changes.
AnnaMag
force-pushed
the
vm-tests_known_issues
branch
from
6dc6f09 to
8667063
Compare
December 16, 2016 16:05
Fishrock123
approved these changes
Dec 16, 2016
Fishrock123
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
Sorry, something went wrong.
cjihrig
approved these changes
Dec 16, 2016
Copy link
Copy Markdown
Sorry, something went wrong.
cjihrig
pushed a commit
to cjihrig/node
that referenced
this pull request
Dec 20, 2016
Deleting property in the vm context has no effect as reported in nodejs#6287 The test is moved to the known_issues and will be fixed with the 5.5 V8 API changes. PR-URL: nodejs#10272 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Merged
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
tests
Description of change
A test addressing #6287:
Deleting property in the vm context has no effect
is added to the known_issues directory.
It will be fixed with the 5.5 V8 API changes