src, lib: deprecate old debug-agent and CLI debugger - #10276
Conversation
Sorry, something went wrong.
Print a warning if --debug or debug are used on the command line. PR-URL: <tbd> Reviewed-By: <tbd> Reviewed-By: <tbd>
|
Do we want to just pull in the soft deprecation (doc update) into this PR as well or is that taken care of in another place? |
Sorry, something went wrong.
I'd be inclined to put that in as a separate PR so that it doesn't get held up in case there are issues with a runtime deprecation. Is anyone stepping up to do the doc deprecation? I guess it would just be a note in doc/api/debugger.md? |
Sorry, something went wrong.
|
Since I couldn't find a PR that does it yet: #10320 |
Sorry, something went wrong.
| stdout = stdout || process.stdout; | ||
|
|
||
| const args = [`--debug-brk=${exports.port}`].concat(argv); | ||
| console.error('`node debug` is deprecated, use `node inspect` instead.\n'); |
There was a problem hiding this comment.
If possible, this should be updated to use process.emitWarning() and DeprecationWarning instead.
Sorry, something went wrong.
Sorry, something went wrong.
Checklist
Affected core subsystem(s)
src, debugger
Description of change
Per #9789 the old V8 debugger and its protocol are on their way out 👋 .
This prints a deprecation warning to stderr when node is invoked with --debug or debug. --debug starts the debug-agent within the process; debug starts Node's builtin CLI debugger. Both utilize the old V8 debugger protocol.
V8 inspector and --inspect replace --debug. Work is underway to replace the CLI debugger (i.e. node debug), see #10187.
I didn't use util.deprecate on the _debugger.start() function because it would print within the repl, i.e. prefixed with debug> .
/cc @nodejs/diagnostics