FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: stream readable resumeScheduled state by italoacasas · Pull Request #10299 · nodejs/node · GitHub

/ node Public

test: stream readable resumeScheduled state - #10299

Closed
italoacasas wants to merge 1 commit into
nodejs:masterfrom
italoacasas:test/stream-readable-resumeScheduled
ConversationCommits (1)ChecksFiles changed
Closed

test: stream readable resumeScheduled state#10299
italoacasas wants to merge 1 commit into
nodejs:masterfrom
italoacasas:test/stream-readable-resumeScheduled

Conversation

italoacasas commented Dec 16, 2016 •
edited
Loading

Copy link
Copy Markdown
Checklist
  • make -j4 test (UNIX), or vcbuild test nosign (Windows) passes
  • tests and/or benchmarks are included
  • commit message follows commit guidelines
Affected core subsystem(s)

test

Description of change

Adding test for the resumeScheduled state in stream.Readable

Ref: #8683
CI: https://ci.nodejs.org/job/node-test-pull-request/5446/console

cc: @mcollina

italoacasas added stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests. labels Dec 16, 2016
addaleax approved these changes Dec 16, 2016
View reviewed changes

addaleax left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM up to the linter errors CI is showing

mcollina requested changes Dec 16, 2016
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you please add checks also for on('data') and pipe()? Both of those trigger a resume().

cjihrig requested changes Dec 16, 2016
View reviewed changes
Comment thread test/parallel/test-stream-readable-resumeScheduled.js Outdated

cjihrig Dec 16, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Can you separate these using block scopes, as done in a lot of other tests. Then, you can reuse the same variable names.

italoacasas Dec 16, 2016

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

ok

italoacasas commented Dec 17, 2016

Copy link
Copy Markdown
Author

ping @cjihrig @mcollina

cjihrig requested changes Dec 17, 2016
View reviewed changes
Comment thread test/parallel/test-stream-readable-resumeScheduled.js Outdated

cjihrig Dec 17, 2016

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

I would drop the "First test," "Second test," etc. from the comments. They will likely become out of date as people change the file.

mcollina approved these changes Dec 19, 2016
View reviewed changes

mcollina left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM

italoacasas commented Dec 20, 2016

Copy link
Copy Markdown
Author

Landed 6137983

cjihrig pushed a commit to cjihrig/node that referenced this pull request Dec 20, 2016
test: stream readable resumeScheduled state
cc9b4b7 
PR-URL: nodejs#10299
Ref: nodejs#8683
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
italoacasas mentioned this pull request Dec 20, 2016
Merged
cjihrig pushed a commit that referenced this pull request Dec 20, 2016
test: stream readable resumeScheduled state
badb1dd 
PR-URL: #10299
Ref: #8683
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
test: stream readable resumeScheduled state
4d2e71b 
PR-URL: #10299
Ref: #8683
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
test: stream readable resumeScheduled state
6b8c4ab 
PR-URL: #10299
Ref: #8683
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
test: stream readable resumeScheduled state
cf1587a 
PR-URL: #10299
Ref: #8683
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
test: stream readable resumeScheduled state
93ed114 
PR-URL: #10299
Ref: #8683
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
test: stream readable resumeScheduled state
d644821 
PR-URL: #10299
Ref: #8683
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
test: stream readable resumeScheduled state
959860f 
PR-URL: #10299
Ref: #8683
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
test: stream readable resumeScheduled state
fd195b4 
PR-URL: #10299
Ref: #8683
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

mcollina mcollina approved these changes
addaleax addaleax approved these changes
cjihrig cjihrig approved these changes

Assignees

No one assigned

Labels

stream Issues and PRs related to the stream subsystem. test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL