test: fix and improve debugger-client test - #10371
Closed
thefourtheye wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
thefourtheye
force-pushed
the
fix-test-debugger-client
branch
from
a9c33e4 to
e8995ce
Compare
December 21, 2016 02:19
cjihrig
approved these changes
Dec 21, 2016
sam-github
approved these changes
Dec 21, 2016
Copy link
Copy Markdown
Member
|
You would probably do @thealphanerd a favor by figuring out how to backport sooner rather than later. I'm thinking specifically about the file that was renamed twice. (Is it one of the old names in v4 or v6? If so, then this won't work and we'll need a different PR for those) |
Sorry, something went wrong.
Trott
reviewed
Dec 21, 2016
Comment thread
test/debugger/test-debugger-client.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nit: Maybe leave a space at the end of the regexp? /Debugger listening on /
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Ack.
Sorry, something went wrong.
Trott
reviewed
Dec 21, 2016
Comment thread
test/debugger/test-debugger-client.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
Nit: While you're in here, maybe remove brk as a callback argument. It is unused.
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Done!
Sorry, something went wrong.
Trott
approved these changes
Dec 21, 2016
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM. Left a couple of nits. Also, two other callback arguments appear to be unused, if you want to clean those up too: res on line 19 and c on line 140.
Sorry, something went wrong.
This test expects the string 'Debugger listening on port' on stderr and since the message has been changed to 'Debugger listening on host:port' this was failing always. Apart from that, this test expects the main script's name to be `src/node.js`, but that has been renamed to `lib/internal/node.js` and then to `lib/internal/bootstrap_node.js`. So, the script name has been updated. Apart from that, using `const` instead of `var` wherever possible. Refer: nodejs#10361
thefourtheye
force-pushed
the
fix-test-debugger-client
branch
from
e8995ce to
2df054b
Compare
December 21, 2016 06:20
Copy link
Copy Markdown
Contributor
Author
|
Thanks @Trott. Addressed all the nits. |
Sorry, something went wrong.
jasnell
approved these changes
Dec 23, 2016
Copy link
Copy Markdown
Member
Sorry, something went wrong.
thefourtheye
added a commit
to thefourtheye/io.js
that referenced
this pull request
Dec 26, 2016
This test expects the string 'Debugger listening on port' on stderr and since the message has been changed to 'Debugger listening on host:port' this was failing always. Apart from that, this test expects the main script's name to be `src/node.js`, but that has been renamed to `lib/internal/node.js` and then to `lib/internal/bootstrap_node.js`. So, the script name has been updated. Apart from that, using `const` instead of `var` wherever possible. Refer: nodejs#10361 PR-URL: nodejs#10371 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
This test expects the string 'Debugger listening on port' on stderr and since the message has been changed to 'Debugger listening on host:port' this was failing always. Apart from that, this test expects the main script's name to be `src/node.js`, but that has been renamed to `lib/internal/node.js` and then to `lib/internal/bootstrap_node.js`. So, the script name has been updated. Apart from that, using `const` instead of `var` wherever possible. Refer: #10361 PR-URL: #10371 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
This test expects the string 'Debugger listening on port' on stderr and since the message has been changed to 'Debugger listening on host:port' this was failing always. Apart from that, this test expects the main script's name to be `src/node.js`, but that has been renamed to `lib/internal/node.js` and then to `lib/internal/bootstrap_node.js`. So, the script name has been updated. Apart from that, using `const` instead of `var` wherever possible. Refer: #10361 PR-URL: #10371 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Contributor
|
This does not land cleanly in LTS. Added dont-land label. Please feel free to manually backport |
Sorry, something went wrong.
thefourtheye
added a commit
to thefourtheye/io.js
that referenced
this pull request
Feb 5, 2017
This test expects the string 'Debugger listening on port' on stderr and since the message has been changed to 'Debugger listening on host:port' this was failing always. Apart from that, this test expects the main script's name to be `src/node.js`, but that has been renamed to `lib/internal/node.js` and then to `lib/internal/bootstrap_node.js`. So, the script name has been updated. Apart from that, using `const` instead of `var` wherever possible. Refer: nodejs#10361 PR-URL: nodejs#10371 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Mar 8, 2017
This test expects the string 'Debugger listening on port' on stderr and since the message has been changed to 'Debugger listening on host:port' this was failing always. Apart from that, this test expects the main script's name to be `src/node.js`, but that has been renamed to `lib/internal/node.js` and then to `lib/internal/bootstrap_node.js`. So, the script name has been updated. Apart from that, using `const` instead of `var` wherever possible. Refer: #10361 PR-URL: #10371 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
This test expects the string 'Debugger listening on port' on stderr and since the message has been changed to 'Debugger listening on host:port' this was failing always. Apart from that, this test expects the main script's name to be `src/node.js`, but that has been renamed to `lib/internal/node.js` and then to `lib/internal/bootstrap_node.js`. So, the script name has been updated. Apart from that, using `const` instead of `var` wherever possible. Refer: #10361 PR-URL: #10371 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test debugger
Description of change
This test expects the string 'Debugger listening on port' on stderr and
since the message has been changed to 'Debugger listening on host:port'
this was failing always.
Apart from that, this test expects the main script's name to be
src/node.js, but that has been renamed to lib/internal/node.js and
then to lib/internal/bootstrap_node.js. So, the script name has been
updated.
Apart from that, using const instead of var wherever possible.
Refer: #10361