test: refactor test-init.js - #10384
Closed
thefourtheye wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
addaleax
approved these changes
Dec 21, 2016
addaleax
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
LGTM with 2 suggestions
Sorry, something went wrong.
Comment thread
test/sequential/test-init.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
typos: it’s and dependent (unrelated to this PR, but while you’re here… ;))
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Done!
Sorry, something went wrong.
Comment thread
test/sequential/test-init.js
Outdated
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
I may be wrong but from the looks of it the copying is kind of pointless?
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
There was a problem hiding this comment.
Ack.
Sorry, something went wrong.
1. Lot of repeating code has been refactored to a function 2. Errors in async calls are properly asserted 3. Fail the test if the callbacks are not fired
thefourtheye
force-pushed
the
refactor-test-init
branch
from
68ce176 to
30b840e
Compare
December 21, 2016 11:07
addaleax
approved these changes
Dec 21, 2016
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
julianduque
approved these changes
Dec 21, 2016
jasnell
approved these changes
Dec 23, 2016
julianduque
pushed a commit
that referenced
this pull request
Dec 23, 2016
1. Lot of repeating code has been refactored to a function 2. Errors in async calls are properly asserted 3. Fail the test if the callbacks are not fired PR-URL: #10384 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Julian Duque <julianduquej@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 3, 2017
1. Lot of repeating code has been refactored to a function 2. Errors in async calls are properly asserted 3. Fail the test if the callbacks are not fired PR-URL: #10384 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Julian Duque <julianduquej@gmail.com>
evanlucas
pushed a commit
that referenced
this pull request
Jan 4, 2017
1. Lot of repeating code has been refactored to a function 2. Errors in async calls are properly asserted 3. Fail the test if the callbacks are not fired PR-URL: #10384 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Julian Duque <julianduquej@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 23, 2017
1. Lot of repeating code has been refactored to a function 2. Errors in async calls are properly asserted 3. Fail the test if the callbacks are not fired PR-URL: #10384 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Julian Duque <julianduquej@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Jan 24, 2017
1. Lot of repeating code has been refactored to a function 2. Errors in async calls are properly asserted 3. Fail the test if the callbacks are not fired PR-URL: #10384 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Julian Duque <julianduquej@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Jan 31, 2017
1. Lot of repeating code has been refactored to a function 2. Errors in async calls are properly asserted 3. Fail the test if the callbacks are not fired PR-URL: #10384 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Julian Duque <julianduquej@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
test
Description of change