doc,src: clarify doc/comment about ABI number - #10419
Closed
Trott wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
Copy link
Copy Markdown
Member
Author
Sorry, something went wrong.
Trott
force-pushed
the
process.versions.module
branch
from
2d92efc to
67e8a65
Compare
December 23, 2016 01:44
Copy link
Copy Markdown
Member
Author
|
Whoops, looks like this will conflict with #10414. I'll remove the change to node_version.h in this PR and defer to the version in that PR. This will still update the doc file. |
Sorry, something went wrong.
Trott
force-pushed
the
process.versions.module
branch
from
67e8a65 to
26894b9
Compare
December 23, 2016 02:05
1 task
Trott
force-pushed
the
process.versions.module
branch
from
26894b9 to
15c72c3
Compare
December 24, 2016 17:57
Copy link
Copy Markdown
Member
Author
|
@nodejs/documentation |
Sorry, something went wrong.
Trott
force-pushed
the
process.versions.module
branch
from
15c72c3 to
89906ed
Compare
December 28, 2016 04:22
Copy link
Copy Markdown
Member
Author
|
Bump! I think this is ready to land if anyone wants to read it. Should be a rather quick review... |
Sorry, something went wrong.
Trott
force-pushed
the
process.versions.module
branch
from
89906ed to
3c10feb
Compare
December 28, 2016 04:25
jasnell
approved these changes
Dec 28, 2016
targos
approved these changes
Dec 28, 2016
thefourtheye
approved these changes
Dec 28, 2016
thefourtheye
left a comment
Copy link
Copy Markdown
Contributor
There was a problem hiding this comment.
You might want to remove comment from the commit title
Sorry, something went wrong.
Trott
force-pushed
the
process.versions.module
branch
from
3c10feb to
6755347
Compare
December 28, 2016 17:00
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Dec 28, 2016
PR-URL: nodejs#10419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Refs: nodejs#9901 (comment)
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
PR-URL: nodejs#10419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Refs: nodejs#9901 (comment)
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 19, 2017
PR-URL: nodejs#10419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Refs: nodejs#9901 (comment)
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 24, 2017
PR-URL: nodejs#10419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Refs: nodejs#9901 (comment)
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
PR-URL: nodejs#10419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Refs: nodejs#9901 (comment)
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Mar 7, 2017
PR-URL: #10419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Refs: #9901 (comment)
MylesBorins
pushed a commit
that referenced
this pull request
Mar 9, 2017
PR-URL: #10419 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com> Refs: #9901 (comment)
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc src process
Description of change