doc: killSignal option accepts integer values - #10424
Closed
thefourtheye wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
`killSignal` option accepts the signal name or signal number as well.
3 tasks
julianduque
approved these changes
Dec 23, 2016
Copy link
Copy Markdown
Contributor
|
Is this behaviour covered by tests? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
|
@sam-github There are few cases in test/parallel/test-child-process-spawnsync-validation-errors.js, but #10423 has enough cases I believe. |
Sorry, something went wrong.
jasnell
approved these changes
Dec 26, 2016
Copy link
Copy Markdown
Contributor
Author
|
@sam-github This behaviour is already there. #10423 improves the validation. |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
|
I suggest putting docs and tests in the same commit in the future, it makes them "obviously correct". But LGTM as is. |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
This is not landing cleanly in master despite this not showing any conflicts here. Can you rebase and update the PR nevermind! appears to have been a temporary glitch on my end |
Sorry, something went wrong.
jasnell
pushed a commit
that referenced
this pull request
Jan 6, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: #10424 Reviewed-By: Julian Duque <julianduquej@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: nodejs#10424 Reviewed-By: Julian Duque <julianduquej@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 19, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: nodejs#10424 Reviewed-By: Julian Duque <julianduquej@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 24, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: nodejs#10424 Reviewed-By: Julian Duque <julianduquej@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: nodejs#10424 Reviewed-By: Julian Duque <julianduquej@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
thefourtheye
added a commit
to thefourtheye/io.js
that referenced
this pull request
Feb 5, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: nodejs#10424 Reviewed-By: Julian Duque <julianduquej@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
2 tasks
thefourtheye
added a commit
to thefourtheye/io.js
that referenced
this pull request
Feb 5, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: nodejs#10424 Reviewed-By: Julian Duque <julianduquej@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
2 tasks
MylesBorins
pushed a commit
that referenced
this pull request
Feb 6, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: #10424 Reviewed-By: Julian Duque <julianduquej@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: #10424 Reviewed-By: Julian Duque <julianduquej@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
MylesBorins
pushed a commit
that referenced
this pull request
Feb 21, 2017
`killSignal` option accepts the signal name or signal number as well. PR-URL: #10424 Reviewed-By: Julian Duque <julianduquej@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Reviewers
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
doc child_process
Description of change
killSignal option accepts the signal name or signal number as well.