buffer: improve allocation and from(arrayLike) performance by mscdex · Pull Request #10443 · nodejs/node · GitHub

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
commit message follows commit guidelines

Affected core subsystem(s)

buffer

Description of change

Improve Buffer allocation performance (up to ~11%) by making assertSize() inlineable and improve Buffer.from(arrayLike) performance (~50%) by replacing the usage of the in operator when checking for a length property.

Relevant benchmark results:

Buffer allocation:

                                                                   improvement significant      p.value
buffers/buffer-creation.js n=1024 len=10 type="buffer()"                3.67 %         *** 1.907380e-31
buffers/buffer-creation.js n=1024 len=10 type="fast-alloc-fill"         4.34 %         *** 3.497544e-11
buffers/buffer-creation.js n=1024 len=10 type="fast-alloc"              9.94 %         *** 7.596522e-44
buffers/buffer-creation.js n=1024 len=10 type="fast-allocUnsafe"        5.05 %         *** 2.696345e-51
buffers/buffer-creation.js n=1024 len=10 type="slow-allocUnsafe"        3.49 %         *** 1.076653e-07
buffers/buffer-creation.js n=1024 len=10 type="slow"                   11.22 %         *** 5.188153e-61
buffers/buffer-creation.js n=1024 len=1024 type="buffer()"              1.42 %          ** 1.348395e-03
buffers/buffer-creation.js n=1024 len=1024 type="fast-alloc-fill"       2.52 %         *** 1.446582e-06
buffers/buffer-creation.js n=1024 len=1024 type="fast-alloc"            5.38 %         *** 1.283277e-27
buffers/buffer-creation.js n=1024 len=1024 type="fast-allocUnsafe"      2.18 %         *** 2.896226e-06
buffers/buffer-creation.js n=1024 len=1024 type="slow-allocUnsafe"      3.41 %         *** 6.929603e-10
buffers/buffer-creation.js n=1024 len=1024 type="slow"                  9.38 %         *** 1.607505e-56
buffers/buffer-creation.js n=1024 len=2048 type="buffer()"              2.13 %         *** 2.849077e-05
buffers/buffer-creation.js n=1024 len=2048 type="fast-alloc-fill"       2.39 %         *** 1.291052e-07
buffers/buffer-creation.js n=1024 len=2048 type="fast-alloc"            3.96 %         *** 2.701098e-22
buffers/buffer-creation.js n=1024 len=2048 type="fast-allocUnsafe"      1.57 %         *** 5.975363e-04
buffers/buffer-creation.js n=1024 len=2048 type="slow-allocUnsafe"      4.54 %         *** 3.838296e-15
buffers/buffer-creation.js n=1024 len=2048 type="slow"                  8.52 %         *** 6.733714e-46
buffers/buffer-creation.js n=1024 len=4096 type="buffer()"              3.62 %         *** 1.399411e-10
buffers/buffer-creation.js n=1024 len=4096 type="fast-alloc-fill"       1.85 %         *** 2.706257e-05
buffers/buffer-creation.js n=1024 len=4096 type="fast-alloc"            1.30 %         *** 1.625928e-04
buffers/buffer-creation.js n=1024 len=4096 type="fast-allocUnsafe"      4.14 %         *** 4.122709e-15
buffers/buffer-creation.js n=1024 len=4096 type="slow-allocUnsafe"      3.78 %         *** 5.601502e-13
buffers/buffer-creation.js n=1024 len=4096 type="slow"                  8.09 %         *** 6.466906e-46
buffers/buffer-creation.js n=1024 len=8192 type="buffer()"              2.54 %         *** 1.426874e-05
buffers/buffer-creation.js n=1024 len=8192 type="fast-alloc-fill"       1.16 %          ** 1.392665e-03
buffers/buffer-creation.js n=1024 len=8192 type="fast-alloc"            0.83 %          ** 2.391328e-03
buffers/buffer-creation.js n=1024 len=8192 type="fast-allocUnsafe"      5.33 %         *** 1.811794e-19
buffers/buffer-creation.js n=1024 len=8192 type="slow-allocUnsafe"      4.85 %         *** 1.764478e-16
buffers/buffer-creation.js n=1024 len=8192 type="slow"                  8.18 %         *** 1.006915e-42

Buffer.from(arrayLike):

                                                       improvement significant      p.value
buffers/buffer-from.js n=10024 len=10 source="object"       48.85 %         *** 4.055606e-41
buffers/buffer-from.js n=10024 len=2048 source="object"     49.44 %         *** 2.809991e-51

/cc @nodejs/buffer
CI: https://ci.nodejs.org/job/node-test-pull-request/5580/

Is this intentional?

Nope. Removed.

LGTM with a question.

assertSize() is adjusted to be inlineable according to V8's default function size limits when determining inlineability. This results in up to 11% performance gains when allocating any kind of Buffer.

This change results in ~50% improvement when creating a Buffer from an array-like object.

Probably too tangentially related to this PR to be worth doing, but just in case: There's a != on line 172 of lib/buffer.js that seems to be calling out to be replaced with !==.

LGTM after CI.

CI: https://ci.nodejs.org/job/node-test-pull-request/5604/

assertSize() is adjusted to be inlineable according to V8's default function size limits when determining inlineability. This results in up to 11% performance gains when allocating any kind of Buffer. Avoid avoids use of in, resulting in ~50% improvement when creating a Buffer from an array-like object. PR-URL: #10443 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Landed in 13a4887

assertSize() is adjusted to be inlineable according to V8's default function size limits when determining inlineability. This results in up to 11% performance gains when allocating any kind of Buffer. Avoid avoids use of in, resulting in ~50% improvement when creating a Buffer from an array-like object. PR-URL: #10443 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Notable changes: * buffer: - Improve performance of Buffer allocation by ~11% (Brian White) #10443 - Improve performance of Buffer.from() by ~50% (Brian White) #10443 * events: Improve performance of EventEmitter.once() by ~27% (Brian White) #10445 * http: Improve performance of http server by ~7% (Brian White) #6533

assertSize() is adjusted to be inlineable according to V8's default function size limits when determining inlineability. This results in up to 11% performance gains when allocating any kind of Buffer. Avoid avoids use of in, resulting in ~50% improvement when creating a Buffer from an array-like object. PR-URL: #10443 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net>

Notable changes: * buffer: - Improve performance of Buffer allocation by ~11% (Brian White) #10443 - Improve performance of Buffer.from() by ~50% (Brian White) #10443 * events: Improve performance of EventEmitter.once() by ~27% (Brian White) #10445 * fs: Allow passing Uint8Array to fs methods where Buffers are supported. (Anna Henningsen) #10382 * http: Improve performance of http server by ~7% (Brian White) #6533 * npm: Upgrade to v4.0.5 (Kat Marchán) #10330 PR-URL: #10589

Adding LTS watch, likely should bake a bit longer before landing.

Notable changes: * buffer: - Improve performance of Buffer allocation by ~11% (Brian White) nodejs/node#10443 - Improve performance of Buffer.from() by ~50% (Brian White) nodejs/node#10443 * events: Improve performance of EventEmitter.once() by ~27% (Brian White) nodejs/node#10445 * fs: Allow passing Uint8Array to fs methods where Buffers are supported. (Anna Henningsen) nodejs/node#10382 * http: Improve performance of http server by ~7% (Brian White) nodejs/node#6533 * npm: Upgrade to v4.0.5 (Kat Marchán) nodejs/node#10330 PR-URL: nodejs/node#10589 Signed-off-by: Ilkka Myller <ilkka.myller@nodefield.com>

mscdex added the buffer Issues and PRs related to the buffer subsystem. label Dec 25, 2016

nodejs-github-bot added buffer Issues and PRs related to the buffer subsystem. dont-land-on-v7.x labels Dec 25, 2016

mscdex added the performance Issues and PRs related to the performance of Node.js. label Dec 25, 2016

mscdex changed the title Buffer allocate perf buffer: improve allocation and from(arrayLike) performance Dec 25, 2016

mscdex removed the dont-land-on-v7.x label Dec 25, 2016

jasnell approved these changes Dec 25, 2016

View reviewed changes

cjihrig reviewed Dec 25, 2016

View reviewed changes

cjihrig approved these changes Dec 25, 2016

View reviewed changes

mscdex added 2 commits December 25, 2016 00:35

buffer: improve allocation performance

b6dba12

assertSize() is adjusted to be inlineable according to V8's default function size limits when determining inlineability. This results in up to 11% performance gains when allocating any kind of Buffer.

buffer: avoid 'in' operator

801493c

This change results in ~50% improvement when creating a Buffer from an array-like object.

mscdex force-pushed the buffer-allocate-perf branch from 896d097 to 801493c Compare December 25, 2016 05:35

nodejs-github-bot added the dont-land-on-v7.x label Dec 25, 2016

mscdex removed the dont-land-on-v7.x label Dec 25, 2016

lpinca approved these changes Dec 25, 2016

View reviewed changes

ChALkeR approved these changes Dec 25, 2016

View reviewed changes

addaleax approved these changes Dec 25, 2016

View reviewed changes

mscdex mentioned this pull request Dec 26, 2016

lib,src: make constants not inherit from Object #10458

Closed

3 tasks

jasnell closed this Dec 27, 2016

mscdex deleted the buffer-allocate-perf branch December 29, 2016 02:20

mscdex mentioned this pull request Dec 31, 2016

http: various performance improvements #10558

Merged

3 tasks

evanlucas mentioned this pull request Jan 3, 2017

v7.4.0 release proposal #10589

Merged

mysticatea mentioned this pull request Jan 19, 2017

Update: rewrite TokenStore (fixes #7810) eslint/eslint#7936

Merged

MylesBorins added lts-watch-v4.x labels Jan 23, 2017

shiftkey mentioned this pull request Mar 29, 2017

update tooling to node v7 and npm v4 desktop/desktop#1085

Closed

MylesBorins added baking-for-lts PRs that need to wait before landing in a LTS release. and removed lts-watch-v4.x labels May 8, 2017

MylesBorins removed the baking-for-lts PRs that need to wait before landing in a LTS release. label Aug 17, 2018

buffer: improve allocation and from(arrayLike) performance by mscdex · Pull Request #10443 · nodejs/node · GitHub

Uh oh!

Uh oh!

buffer: improve allocation and from(arrayLike) performance - #10443

buffer: improve allocation and from(arrayLike) performance#10443
mscdex wants to merge 2 commits into
nodejs:masterfrom
mscdex:buffer-allocate-perf

mscdex commented Dec 25, 2016 •
edited
Loading

Uh oh!

Uh oh!

cjihrig Dec 25, 2016

Uh oh!

mscdex Dec 25, 2016

Uh oh!

cjihrig left a comment

Uh oh!

Trott commented Dec 25, 2016 •
edited
Loading

Uh oh!

Uh oh!

ChALkeR left a comment

Uh oh!

jasnell commented Dec 27, 2016

Uh oh!

jasnell commented Dec 27, 2016

Uh oh!

MylesBorins commented Jan 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

buffer: improve allocation and from(arrayLike) performance by mscdex · Pull Request #10443 · nodejs/node · GitHub

Uh oh!

Uh oh!

buffer: improve allocation and from(arrayLike) performance - #10443

buffer: improve allocation and from(arrayLike) performance#10443mscdex wants to merge 2 commits intonodejs:masternodejs/node:masterfrom mscdex:buffer-allocate-perfmscdex/io.js:buffer-allocate-perfCopy head branch name to clipboard

Conversation

mscdex commented Dec 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Checklist

Affected core subsystem(s)

Description of change

Uh oh!

cjihrig Dec 25, 2016

Choose a reason for hiding this comment

Uh oh!

mscdex Dec 25, 2016

Choose a reason for hiding this comment

Uh oh!

cjihrig left a comment

Choose a reason for hiding this comment

Uh oh!

Trott commented Dec 25, 2016 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

ChALkeR left a comment

Choose a reason for hiding this comment

Uh oh!

jasnell commented Dec 27, 2016

Uh oh!

jasnell commented Dec 27, 2016

Uh oh!

MylesBorins commented Jan 23, 2017

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

9 participants

buffer: improve allocation and from(arrayLike) performance#10443
mscdex wants to merge 2 commits into
nodejs:masterfrom
mscdex:buffer-allocate-perf

mscdex commented Dec 25, 2016 •
edited
Loading

Trott commented Dec 25, 2016 •
edited
Loading