src: always initialize tracing controller in agent - #10507
Closed
matthewloring wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Sorry, something went wrong.
Copy link
Copy Markdown
Author
Sorry, something went wrong.
cjihrig
approved these changes
Dec 28, 2016
jasnell
approved these changes
Dec 28, 2016
Copy link
Copy Markdown
Author
|
CI failures all look unrelated |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
It's fine that this landed but typically we need to wait 48 hours before landing any pr that is not considered trivial... Which is usually limited to doc only or meta prs. |
Sorry, something went wrong.
Copy link
Copy Markdown
Author
|
Apologies, I will hold off in the future. |
Sorry, something went wrong.
This was referenced Jan 19, 2017
Copy link
Copy Markdown
Contributor
|
Marking don't land since it depends on #9304 |
Sorry, something went wrong.
targos
pushed a commit
to targos/node
that referenced
this pull request
Mar 1, 2017
PR-URL: nodejs#10507 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Mar 1, 2017
PR-URL: nodejs#10507 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
Copy link
Copy Markdown
Member
|
Marking as don't land on 4 and 6 because #9304 is marked don't land |
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Checklist
Affected core subsystem(s)
src
Description of change