FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: s/assert.notEqual()/assert.notStrictEqual()/ by cjihrig · Pull Request #10541 · nodejs/node · GitHub

/ node Public

test: s/assert.notEqual()/assert.notStrictEqual()/ - #10541

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:not-equal
Jan 6, 2017
ConversationCommits (1)ChecksFiles changed
Merged

test: s/assert.notEqual()/assert.notStrictEqual()/#10541
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:not-equal

Conversation

cjihrig commented Dec 30, 2016

Copy link
Copy Markdown
Contributor
Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added the test Issues and PRs related to the tests. label Dec 30, 2016

cjihrig commented Dec 30, 2016

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/5638/

Trott approved these changes Dec 31, 2016
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is ✅ . Left some nits, but they can be ignored and someone can do them later if they feel strongly about it.

Comment thread test/parallel/test-console.js Outdated

Trott Dec 31, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

For readability, might be good to change this to assert(strings.shift().includes('foo: [Object]'));

Comment thread test/parallel/test-crypto-fips.js Outdated

Trott Dec 31, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Might be good to use .includes() here and change assert.notStrictEqual() to assert().

Comment thread test/parallel/test-module-loading-error.js Outdated

Trott Dec 31, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Same.

Comment thread test/parallel/test-module-loading-error.js Outdated

Trott Dec 31, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Ditto.

Comment thread test/parallel/test-net-remote-address-port.js Outdated

Trott Dec 31, 2016

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

Here and the next line too. I'll stop. You get the idea. :-D

Trott commented Dec 31, 2016

Copy link
Copy Markdown
Member

Nit: commit message should start with an imperative verb. Although I guess arguably the s/.../ is substitute and that's an imperative verb, so...
¯\(ツ)/¯

cjihrig commented Jan 2, 2017

Copy link
Copy Markdown
Contributor Author

FWIW, I went with s/.../ to work within the 50 character limit.

cjihrig commented Jan 6, 2017

Copy link
Copy Markdown
Contributor Author

New CI with @Trott's suggestions: https://ci.nodejs.org/job/node-test-pull-request/5729/

test: s/assert.notEqual()/assert.notStrictEqual()/
e5499b3 
PR-URL: nodejs#10541
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
cjihrig merged commit e5499b3 into nodejs:master Jan 6, 2017
cjihrig deleted the not-equal branch January 6, 2017 19:11
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 18, 2017
test: s/assert.notEqual()/assert.notStrictEqual()/
5d0aa40 
PR-URL: nodejs#10541
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 19, 2017
test: s/assert.notEqual()/assert.notStrictEqual()/
9e4d439 
PR-URL: nodejs#10541
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas mentioned this pull request Jan 25, 2017
Closed
targos pushed a commit that referenced this pull request Jan 28, 2017
test: s/assert.notEqual()/assert.notStrictEqual()/
bb71ef7 
PR-URL: #10541
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas mentioned this pull request Jan 29, 2017
Merged
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
test: s/assert.notEqual()/assert.notStrictEqual()/
5013022 
PR-URL: nodejs#10541
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>
italoacasas pushed a commit to italoacasas/node that referenced this pull request Jan 30, 2017
test: s/assert.notEqual()/assert.notStrictEqual()/
37d1f56 
PR-URL: nodejs#10541
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Italo A. Casas <me@italoacasas.com>

jasnell commented Mar 8, 2017

Copy link
Copy Markdown
Member

This will need backport PRs to land on v4 and v6

This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
+3 more reviewers
sam-github sam-github approved these changes
italoacasas italoacasas approved these changes
gibfahn gibfahn approved these changes
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

8 participants

Back | FazBrowse Home | New Git URL