FazBrowse GitHub Viewer | Trending |
URL:
| Home
Tools: [Download Repo ZIP]   [Original HTTPS Page]

test: avoid assigning this to variables by cjihrig · Pull Request #10548 · nodejs/node · GitHub

/ node Public

test: avoid assigning this to variables - #10548

Merged
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:no-self
Jan 2, 2017
ConversationCommits (1)ChecksFiles changed
Merged

test: avoid assigning this to variables#10548
cjihrig merged 1 commit into
nodejs:masterfrom
cjihrig:no-self

Conversation

cjihrig commented Dec 30, 2016

Copy link
Copy Markdown
Contributor

This commit removes assignments of this to a variable in the tests.

There are still two cases of var self = this; in the tests.

  • test/parallel/test-cluster-shared-handle-bind-error.js - fixed in a separate currently open PR.
  • test/parallel/test-http-client-read-in-error.js - I could fix this, but it actually seems more readable with self.

This could optionally be added to the linter moving forward.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines
Affected core subsystem(s)

test

nodejs-github-bot added test Issues and PRs related to the tests. lts-watch-v6.x labels Dec 30, 2016

cjihrig commented Dec 30, 2016

Copy link
Copy Markdown
Contributor Author

CI: https://ci.nodejs.org/job/node-test-pull-request/5646/

Trott approved these changes Dec 31, 2016
View reviewed changes

Trott left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Choose a reason Spam Abuse Off Topic Outdated Duplicate Resolved Low Quality

LGTM if CI is ✅

test: avoid assigning this to variables
1d11b47 
This commit removes assignments of this to a variable in the
tests.

PR-URL: nodejs#10548
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
cjihrig merged commit 1d11b47 into nodejs:master Jan 2, 2017
cjihrig deleted the no-self branch January 2, 2017 15:05
evanlucas mentioned this pull request Jan 3, 2017
Merged
evanlucas pushed a commit that referenced this pull request Jan 3, 2017
test: avoid assigning this to variables
2ebd095 
This commit removes assignments of this to a variable in the
tests.

PR-URL: #10548
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
evanlucas pushed a commit that referenced this pull request Jan 4, 2017
test: avoid assigning this to variables
32401b5 
This commit removes assignments of this to a variable in the
tests.

PR-URL: #10548
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
test: avoid assigning this to variables
79661ba 
This commit removes assignments of this to a variable in the
tests.

PR-URL: #10548
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
test: avoid assigning this to variables
d83112a 
This commit removes assignments of this to a variable in the
tests.

PR-URL: #10548
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 23, 2017
test: avoid assigning this to variables
0aa900f 
This commit removes assignments of this to a variable in the
tests.

PR-URL: #10548
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
test: avoid assigning this to variables
6971630 
This commit removes assignments of this to a variable in the
tests.

PR-URL: #10548
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 24, 2017
test: avoid assigning this to variables
d70a40c 
This commit removes assignments of this to a variable in the
tests.

PR-URL: #10548
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This was referenced Jan 24, 2017
Merged
Merged
MylesBorins pushed a commit that referenced this pull request Jan 31, 2017
test: avoid assigning this to variables
e34af8d 
This commit removes assignments of this to a variable in the
tests.

PR-URL: #10548
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
MylesBorins pushed a commit that referenced this pull request Feb 1, 2017
test: avoid assigning this to variables
f5e54f5 
This commit removes assignments of this to a variable in the
tests.

PR-URL: #10548
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters. Learn more about bidirectional Unicode characters
Show hidden characters
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

jasnell jasnell approved these changes
Trott Trott approved these changes
lpinca lpinca approved these changes

Assignees

No one assigned

Labels

test Issues and PRs related to the tests.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

Back | FazBrowse Home | New Git URL