test: use const for all require() calls - #10550
Merged
cjihrig merged 1 commit intoJan 2, 2017
Merged
Conversation
Copy link
Copy Markdown
Contributor
Sorry, something went wrong.
Trott
approved these changes
Dec 31, 2016
Trott
left a comment
Copy link
Copy Markdown
Member
There was a problem hiding this comment.
CHUUUUURRRRNNNN!!!! But that's fine by me in this case. LGTM if CI is ✅
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
CI: https://ci.nodejs.org/job/node-test-commit/6946/console And there's already a merge conflict... |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
PR-URL: nodejs#10550 Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
PR-URL: nodejs#10550 Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 19, 2017
PR-URL: nodejs#10550 Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jan 28, 2017
PR-URL: #10550 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10550 Reviewed-By: Rich Trott <rtrott@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 30, 2017
PR-URL: nodejs#10550 Reviewed-By: Rich Trott <rtrott@gmail.com>
Copy link
Copy Markdown
Contributor
|
@cjihrig could you backport to v4 / v6? |
Sorry, something went wrong.
Copy link
Copy Markdown
Contributor
Author
Sorry, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This commit assigns the results of every require() to a const variable. This follows the style used in /lib.
Checklist
Affected core subsystem(s)
test