url: TupleOrigin#toString use unicode by default - #10552
Closed
joyeecheung wants to merge 1 commit into
Closed
Conversation
Copy link
Copy Markdown
Member
Sorry, something went wrong.
See: https://url.spec.whatwg.org/#dom-url-origin Also moves the tests for origins to the parsing tests since now URL#origin matches the test cases by default.
jasnell
approved these changes
Jan 1, 2017
Copy link
Copy Markdown
Member
Author
|
Ping, is there anything else that needs to be addressed? |
Sorry, something went wrong.
Copy link
Copy Markdown
Member
|
I don’t think this got a CI run so far, so: https://ci.nodejs.org/job/node-test-commit/7000/ |
Sorry, something went wrong.
jasnell
pushed a commit
to jasnell/node
that referenced
this pull request
Jan 3, 2017
See: https://url.spec.whatwg.org/#dom-url-origin Also moves the tests for origins to the parsing tests since now URL#origin matches the test cases by default. PR-URL: nodejs#10552 Reviewed-By: James M Snell <jasnell@gmail.com>
Copy link
Copy Markdown
Member
|
oops! Thanks for closing @joyeecheung! Must have hit the wrong button when I added the landing comment :-) |
Sorry, something went wrong.
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 18, 2017
See: https://url.spec.whatwg.org/#dom-url-origin Also moves the tests for origins to the parsing tests since now URL#origin matches the test cases by default. PR-URL: nodejs#10552 Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 19, 2017
See: https://url.spec.whatwg.org/#dom-url-origin Also moves the tests for origins to the parsing tests since now URL#origin matches the test cases by default. PR-URL: nodejs#10552 Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 24, 2017
See: https://url.spec.whatwg.org/#dom-url-origin Also moves the tests for origins to the parsing tests since now URL#origin matches the test cases by default. PR-URL: nodejs#10552 Reviewed-By: James M Snell <jasnell@gmail.com>
italoacasas
pushed a commit
to italoacasas/node
that referenced
this pull request
Jan 27, 2017
See: https://url.spec.whatwg.org/#dom-url-origin Also moves the tests for origins to the parsing tests since now URL#origin matches the test cases by default. PR-URL: nodejs#10552 Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See: https://url.spec.whatwg.org/#dom-url-origin
Also moves the tests for origins to the parsing tests
since now URL#origin matches the test cases by default.
Aside: maybe the unicode argument can be removed since from what I've found so far the spec doesn't use domain to ASCII serialization for origins and https://coverage.nodejs.org/coverage-abc1633de649bfa5/root/internal/url.js.html shows that the unicode === false is never taken in tests.
Checklist
Affected core subsystem(s)
url
cc / @jasnell