tools: update ESLint to current version by Trott · Pull Request #10561 · nodejs/node · GitHub

We have been stalled on ESLint 3.8.0 for some time. Current ESLint is
3.12.2. We have been unable to upgrade because of more aggressive
reporting on some rules, including indentation.

ESLint configuration options and bugfixes are now such that we can
reasonably upgrade.

ESLint `indent` rule now has options that duplicate functionality in our
custom `align-function-arguments` rule. Remove
`align-function-arguments` custom rule.

The `no-useless-regex-char-class-escape` custom lint rule was introduced
as a less aggressive alternative to some enhancements that were
introduced into ESLint. Those enhancements were blocking us from
updating ESLint. However, they have since been relaxed and the custom
rule is no longer needed. Remove it.

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
commit message follows commit guidelines

Affected core subsystem(s)

tools benchmark test lib

CI: https://ci.nodejs.org/job/node-test-pull-request/5653/

LGTM

I noticed that this was installed from ESLint's latest master (eslint/eslint@c5c3b21), which is slightly ahead of the v3.12.2 release. I assume this is because eslint/eslint@f20b9e9, which we need in order to upgrade, hasn't made it into a release yet. Would it be worth waiting until Friday so that we can use a version that appears in a release?

(I'm not sure whether there is actually a compelling reason to wait, but I thought I'd raise the question.)

@not-an-aardvark If it's only going to be a few days, I'd say it's worth waiting, then we can just say eslint is v3.12.3 without having to talk about commits.

I'm assuming there's nothing that we urgently need in here...

options and bufixes are

"bugfixes"?

LGTM, but it would be better to use an officially released version rather than an install from master if possible.

Rubber stamp lgtm

@Trott... did you see @sam-github's comment here #10561 (comment) with regards to using a released version vs. an image from master?

@Trott... did you see @sam-github's comment here #10561 (comment) with regards to using a released version vs. an image from master?

Waiting for an official release we can use. Should be coming out tomorrow, as ESLint does releases on Fridays. If there's no deal-breaker bugs for us, should be able to use that and merge this tomorrow. (Been tracking master on this branch specifically to catch bugs that will affect us sooner than the release.)

Formatting changes for upcoming linter update.

We have been stalled on ESLint 3.8.0 for some time. Current ESLint is 3.13.0. We have been unable to upgrade because of more aggressive reporting on some rules, including indentation. ESLint configuration options and bugfixes are now such that we can reasonably upgrade.

ESLint `indent` rule now has options that duplicate functionality in our custom `align-function-arguments` rule. Remove `align-function-arguments` custom rule.

The `no-useless-regex-char-class-escape` custom lint rule was introduced as a less aggressive alternative to some enhancements that were introduced into ESLint. Those enhancements were blocking us from updating ESLint. However, they have since been relaxed and the custom rule is no longer needed. Remove it.

ESLint 3.13.0

CI: https://ci.nodejs.org/job/node-test-pull-request/5739/